From 746ecf7e12b5ec6a491f3bd5fa00a687fdf050fd Mon Sep 17 00:00:00 2001
From: Hammat Wele <hammat.wele@inlibro.com>
Date: Mon, 25 Mar 2024 16:21:11 +0000
Subject: [PATCH] Bug 31736: Editing 'All' to 'All patron categories'

This patch edit the term 'All' to 'All patron categories', beacause All can have different genders depending on the used language ( in french All could mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All patron categories'
   --> No spelling errors in 'All' patron categories

   - Administration > Circulation and fines rules > Patron category column ('All patron categories' in existing rule)
   - Administration > Circulation and fines rules > Patron category column ('All patron categories' in drop-down to create a new rule)
   - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Patron category column ('All patron categories' in existing rule)
   - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Patron category column ('All patron categories' in drop-down to create a new rule)
   - Administration > Circulation and fines rules > Default article request fees > Patron category column ('All patron categories' in existing rule)
   - Administration > Circulation and fines rules > Default article request fees > Patron category column ('All patron categories' in drop-down to create a new rule)
   - Installer > Onboarding > New circulation rule (Patron category)
---
 .../prog/en/modules/admin/smart-rules.tt             | 12 ++++++------
 .../prog/en/modules/onboarding/onboardingstep5.tt    |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
index f1193b1441..ca999dee61 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ -216,7 +216,7 @@
                                                     [% END %]</td>
                                                 <td data-code="[% c | html %]">
                                                     [% IF c == undef %]
-                                                        <em>All</em>
+                                                        <em>All patron categories</em>
                                                     [% ELSE %]
                                                         [% Categories.GetName(c) | html %]
                                                     [% END %]
@@ -412,7 +412,7 @@
                                 <td>2</td>
                                 <td>
                                     <select name="categorycode" id="categorycode">
-                                        <option value="*">All</option>
+                                        <option value="*">All patron categories</option>
                                     [% FOREACH patron_category IN patron_categories%]
                                         <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option>
                                     [% END %]
@@ -910,7 +910,7 @@
                                         <tr>
                                             <td>
                                                 [% IF c == undef %]
-                                                    <em>All</em>
+                                                    <em>All patron categories</em>
                                                 [% ELSE %]
                                                     [% Categories.GetName(c) | html %]
                                                 [% END %]
@@ -939,7 +939,7 @@
                             <tr>
                                 <td>
                                     <select name="waiting_hold_cancellation_category" id="waiting_hold_cancellation_category">
-                                        <option value="*">All</option>
+                                        <option value="*">All patron categories</option>
                                     [% FOREACH patron_category IN patron_categories %]
                                         <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option>
                                     [% END %]
@@ -1047,7 +1047,7 @@
                                 <tr>
                                     <td>
                                         [% IF c == undef %]
-                                            <em>All</em>
+                                            <em>All patron categories</em>
                                         [% ELSE %]
                                             [% Categories.GetName(c) | html %]
                                         [% END %]
@@ -1068,7 +1068,7 @@
                             <tr>
                                 <td>
                                     <select name="article_request_fee_category" id="article_request_fee_category">
-                                        <option value="*">All</option>
+                                        <option value="*">All patron categories</option>
                                     [% FOREACH patron_category IN patron_categories%]
                                         <option value="[% patron_category.categorycode | html %]">[% patron_category.description | html %]</option>
                                     [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
index d86c408615..207e0c298f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
@@ -76,7 +76,7 @@
                                     <label for="categorycode" class="required">Patron category: </label>
                                     <select name="categorycode" id="categorycode" required="required">
                                         <option value=""> Choose</option>
-                                        <option value="*" selected="selected">All</option>
+                                        <option value="*" selected="selected">All patron categories</option>
                                         [% FOREACH category IN categories %]
                                             <option value = "[% category.categorycode | html %]"> [% category.description | html %]</option>
                                         [%END%]
-- 
2.34.1