From 352116408c03b7c32de11223cb84e5ab0157fb81 Mon Sep 17 00:00:00 2001
From: Hammat Wele <hammat.wele@inlibro.com>
Date: Mon, 25 Mar 2024 16:48:04 +0000
Subject: [PATCH] Bug 31736: Editing 'All' to 'All item types'

This patch edit the term 'All' to 'All item types', beacause All can have different genders depending on the used language ( in french All could mean 'tous for 'male-gendered' things and 'toutes' for 'female-gendered' things).

1. Apply patch
2. View the following pages
   --> The pages work (no errors)
   --> 'All' should be replace by 'All item types'
   --> No spelling errors in 'All item types'

   - Administration > Circulation and fines rules > Item types column ('All item types' in existing rule)
   - Administration > Circulation and fines rules > Item types column ('All item types' in drop-down to create a new rule)
   - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Item types column ('All item types' in existing rule)
   - Administration > Circulation and fines rules > Default waiting hold cancellation policy > Item types column ('All item types' in drop-down to create a new rule)
   - Circulation > Hold queue > Item type > 'All item types' in Item type drop-down
   - Reports > Items lost > 'All item types' in Item type drop-down
   - Installer > Onboarding > New circulation rule (Item type)
---
 .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt    | 8 ++++----
 .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 +-
 .../prog/en/modules/onboarding/onboardingstep5.tt         | 2 +-
 .../intranet-tmpl/prog/en/modules/reports/itemslost.tt    | 2 +-
 .../prog/en/modules/serials/subscription-bib-search.tt    | 2 +-
 5 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
index ca999dee61..b16e1c9224 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
@@ -228,7 +228,7 @@
                                                     [% END %]</td>
                                                 <td data-code="[% i | html %]">
                                                     [% IF i == undef %]
-                                                        <em>All</em>
+                                                        <em>All item types</em>
                                                     [% ELSE %]
                                                         [% ItemTypes.GetDescription(i,1) | html %]
                                                     [% END %]
@@ -421,7 +421,7 @@
                                 <td>0</td>
                                 <td>
                                     <select name="itemtype" id="matrixitemtype" style="width:13em;">
-                                        <option value="*">All</option>
+                                        <option value="*">All item types</option>
                                         [% FOREACH itemtypeloo IN itemtypeloop %]
                                             [% NEXT IF itemtypeloo.parent_type %]
                                             [% SET children = itemtypeloo.children_with_localization %]
@@ -917,7 +917,7 @@
                                             </td>
                                             <td>
                                                 [% IF i == undef %]
-                                                    <em>All</em>
+                                                    <em>All item types</em>
                                                 [% ELSE %]
                                                     [% ItemTypes.GetDescription(i,1) | html %]
                                                 [% END %]
@@ -947,7 +947,7 @@
                                 </td>
                                 <td>
                                     <select name="waiting_hold_cancellation_itemtype" id="waiting_hold_cancellation_itemtype">
-                                        <option value="*">All</option>
+                                        <option value="*">All item types</option>
                                     [% FOREACH itemtype IN itemtypeloop %]
                                         <option value="[% itemtype.itemtype | html %]">[% ItemTypes.GetDescription(itemtype.itemtype) | html %]</option>
                                     [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
index 9abbc72e3f..72d6556568 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
@@ -280,7 +280,7 @@
                 <li>
                     <label for="itemtypeslimit">Item type: </label>
                     <select name="itemtypeslimit" id="itemtypeslimit">
-                        <option value="">All</option>
+                        <option value="">All item types</option>
                         [% PROCESS options_for_item_types itemtypes => ItemTypes.Get(), selected_itemtype => itemtypeslimit %]
                     </select>
                 </li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
index 207e0c298f..04778d003c 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt
@@ -88,7 +88,7 @@
                                     <label for="itemtype" class="required">Item type: </label>
                                     <select id="itemtype" name="itemtype" required="required">
                                         <option value=""> Choose </option>
-                                        <option value="*" selected="selected">All</option>
+                                        <option value="*" selected="selected">All item types</option>
                                         [% FOREACH item IN itemtypes %]
                                             <option value = "[% item.itemtype | html %]"> [% item.itemtype | html %]
                                         [%END%]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
index cf8d2de5d3..482deb6efd 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt
@@ -152,7 +152,7 @@
                 [% PROCESS options_for_libraries libraries => Branches.all() %]
             </select></li>
     <li><label for="itemtypesfilter">Item type: </label><select name="itemtypesfilter" id="itemtypesfilter">
-                <option value="">All</option>
+                <option value="">All item types</option>
                 [% FOREACH itemtype IN itemtypes %]
                     <option value="[% itemtype.itemtype | html %]">[% itemtype.translated_description | html %]</option>
                 [% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt
index 7dc24dd0cb..514cfec236 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-bib-search.tt
@@ -23,7 +23,7 @@
         <li>
             <label for="itemtypelimit">Limit item type to: </label>
             <select name="itemtypelimit" id="itemtypelimit">
-                <option value="">All</option>
+                <option value="">All item types</option>
                 [%- FOREACH itemtypeloo IN itemtypeloop %]
                 <option value="[% itemtypeloo.code | html %]">
                     [% itemtypeloo.description | html %]
-- 
2.34.1