From 246f483fed901d71161465a5377a30e0a71df1fa Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 11 Jul 2024 14:47:09 +0200 Subject: [PATCH] Bug 37309: Clear itemnumbers array before 'select all' Otherwise the same itemnumber can appear several times in the array. It could be moved to its own bug but this is only code cleaning it seems, there is no impact on the UX Signed-off-by: Pedro Amorim --- .../en/includes/html_helpers/tables/items/catalogue_detail.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc index 737e3a0a922..03f248234c4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc @@ -130,6 +130,7 @@ e.preventDefault(); let tab_id = $(this).data("tab"); let tab = $("#" + tab_id + "_panel" ); + items_selection[tab_id] = []; tab.find("input[name='itemnumber'][type='checkbox']").each( (i, input) => { let itemnumber = parseInt($(input).val()); items_selection[tab_id].push(itemnumber); -- 2.34.1