From 9216e0f7b18096fbfa89b67843fbc2f220d57e85 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 19 Mar 2013 09:24:18 -0700 Subject: [PATCH] Bug 8015: Fix problem with moving existing subfield value to nonexistent field/subfield Signed-off-by: Leila --- Koha/SimpleMARC.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Koha/SimpleMARC.pm b/Koha/SimpleMARC.pm index f7f872b..1d8c486 100644 --- a/Koha/SimpleMARC.pm +++ b/Koha/SimpleMARC.pm @@ -262,7 +262,7 @@ sub field_equals { sub move_field { my ( $record, $fromFieldName, $fromSubfieldName, $toFieldName, $toSubfieldName, $regex, $n ) = @_; C4::Koha::Log( "C4::SimpleMARC::move_field( '$record', '$fromFieldName', '$fromSubfieldName', '$toFieldName', '$toSubfieldName', '$regex', '$n' )" ) if $debug; - copy_field( $record, $fromFieldName, $fromSubfieldName, $toFieldName, $toSubfieldName, $regex, $n , "don't_erase"); + copy_field( $record, $fromFieldName, $fromSubfieldName, $toFieldName, $toSubfieldName, $regex, $n , 1); delete_field( $record, $fromFieldName, $fromSubfieldName, $n ); } @@ -316,11 +316,11 @@ sub _update_repeatable_field_with_single_value { if ( $subfieldName ) { if ( my @fields = $record->field( $fieldName ) ) { foreach my $field ( @fields ) { - $field->update( "$subfieldName" => $value ); + $field->update( $subfieldName => $value ); } } else { ## Field does not exist, create it. - $field = MARC::Field->new( $fieldName, '', '', "$subfieldName" => $value ); + $field = MARC::Field->new( $fieldName, undef, undef, $subfieldName => $value ); $record->append_fields( $field ); } } else { ## No subfield -- 1.7.10.4