Attachment 170435 Details for Bug 37409 – Bug 37409: Fix 'Edit' button for items in course reserves list

[patch] Bug 37409: Fix 'Edit' button for items in course reserves list

Bug-37409-Fix-Edit-button-for-items-in-course-rese.patch (text/plain), 2.72 KB, created by Marcel de Rooy on 2024-08-16 08:00:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-08-16 08:00:00 UTC

Size: 2.72 KB

patch

obsolete

>From e4b1f8bdee12aa8cbf0904f405af5cbde6213112 Mon Sep 17 00:00:00 2001
>From: Sam Lau <samalau@gmail.com>
>Date: Fri, 26 Jul 2024 20:52:19 +0000
>Subject: [PATCH] Bug 37409: Fix 'Edit' button for items in course reserves
> list
>Content-Type: text/plain; charset=utf-8
>
>To test:
>1) Set the 'UseCourseReserves' sys pref to 'Use'
>2) Go to the Course reserves page
>3) Create a new course, fill in the required info and make sure the 'Enabled?' is checked
>4) Add a reserve to this course
>5) From the course details page, select edit on the reserve you just made.
>6) Note it brings you back to the add reserves page, and you are required to enter the barcode/biblionumber again to edit
>7) Apply patch, restart_all
>8) Press the edit button again
>9) Now you are directed towards the correct page for editing
>10) Make some changes and press save
>11) You should be redirected back to the details page and your changes have been made
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> .../prog/en/modules/course_reserves/course-details.tt           | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>index e9acd983a6..40bc02d74f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>@@ -298,7 +298,7 @@
>                                     [% IF CAN_user_coursereserves_add_reserves || CAN_user_coursereserves_delete_reserves %]
>                                         <td class="actions">
>                                             [% IF CAN_user_coursereserves_add_reserves && logged_in_user.can_edit_items_from( cr.item.homebranch ) %]
>-                                                <a class="btn btn-default btn-xs" href="add_items.pl?course_id=[% course.course_id | html %]&amp;itemnumber=[% cr.item.itemnumber | html %]&amp;biblionumber=[% cr.biblio.biblionumber | html %]&amp;action=lookup&amp;return=[% course.course_id | html %]&amp;is_edit=1"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
>+                                                <a class="btn btn-default btn-xs" href="add_items.pl?course_id=[% course.course_id | html %]&amp;op=lookup&amp;itemnumber=[% cr.item.itemnumber | html %]&amp;biblionumber=[% cr.biblio.biblionumber | html %]&amp;is_edit=1&amp;return=[% course.course_id | html %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a>
>                                             [% END %]
> 
>                                             [% IF CAN_user_coursereserves_delete_reserves %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37409: 169791 | 169792 | 169990 | 170007 | 170025 | 170435