From b61b0dad11d592fd78897f78b7a609734523bc29 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 20 Aug 2024 13:25:26 +0000 Subject: [PATCH] Bug 37636: Remove sort of pending_checkouts by timestamp Renewals or automatic renewal attempts can change the timestamp of an issue and cause a sort on this field to functionally randomize the order of checkouts returned. Prior to bug 19935 the GetPendingCheckouts routine returned items in issuedate order. Removing the sort on timestamp will return the previous behaviour and provide a more predictable sorting To test: 1 - Checkout some items to a patron 2 - Print a checkout slip - items are in the order they were checked out 3 - Renew an item,print the slip again it is now at the top of the list 4 - Apply patch, restart_all 5 - Print slip again - the items are now ordered in the order they were checked out. --- Koha/Patron.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/Koha/Patron.pm b/Koha/Patron.pm index 7234a3be5bc..121073e6793 100644 --- a/Koha/Patron.pm +++ b/Koha/Patron.pm @@ -1438,7 +1438,6 @@ sub pending_checkouts { {}, { order_by => [ - { -desc => 'me.timestamp' }, { -desc => 'issuedate' }, { -desc => 'issue_id' }, # Sort by issue_id should be enough ], -- 2.39.2