From eb3f33f5980cc4dc44458b2bb3202015879c58cd Mon Sep 17 00:00:00 2001
From: Johanna Raisa <johanna.raisa@gmail.com>
Date: Mon, 2 May 2022 11:49:11 +0300
Subject: [PATCH] Bug 30660: Add cancellation reason to holds delete endpoint

This patch adds cancellation reason to holds delete endpoint.

Test plan:
1) prove t/db_dependent/api/v1/holds.t

Sponsored-by: Koha-Suomi Oy
---
 Koha/REST/V1/Holds.pm           | 3 ++-
 api/v1/swagger/paths/holds.yaml | 6 ++++++
 t/db_dependent/api/v1/holds.t   | 2 +-
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/Koha/REST/V1/Holds.pm b/Koha/REST/V1/Holds.pm
index e0d7c5b271..154cd0ea05 100644
--- a/Koha/REST/V1/Holds.pm
+++ b/Koha/REST/V1/Holds.pm
@@ -328,7 +328,8 @@ sub delete {
             );
         }
 
-        $hold->cancel;
+        my $cancellation_reason = $c->req->json;
+        $hold->cancel({ cancellation_reason => $cancellation_reason });
 
         return $c->render_resource_deleted;
     }
diff --git a/api/v1/swagger/paths/holds.yaml b/api/v1/swagger/paths/holds.yaml
index b75ad24e50..b688d81f11 100644
--- a/api/v1/swagger/paths/holds.yaml
+++ b/api/v1/swagger/paths/holds.yaml
@@ -403,6 +403,12 @@
     summary: Cancel hold
     parameters:
       - $ref: "../swagger.yaml#/parameters/hold_id_pp"
+      - name: body
+        in: body
+        description: Cancellation reason
+        required: false
+        schema:
+          type: string
       - name: x-koha-override
         in: header
         required: false
diff --git a/t/db_dependent/api/v1/holds.t b/t/db_dependent/api/v1/holds.t
index 8632c25940..95c9a8cc2a 100755
--- a/t/db_dependent/api/v1/holds.t
+++ b/t/db_dependent/api/v1/holds.t
@@ -234,7 +234,7 @@ subtest "Test endpoints with permission" => sub {
       ->status_is(200)
       ->json_is([]);
 
-    $t->delete_ok( "//$userid_3:$password@/api/v1/holds/$reserve_id2" )
+    $t->delete_ok( "//$userid_3:$password@/api/v1/holds/$reserve_id2" => json => "Cancellation reason" )
       ->status_is(204, 'SWAGGER3.2.4')
       ->content_is('', 'SWAGGER3.3.4');
 
-- 
2.34.1