From d2e72bc7ac85d37b143ea0ebfe732cea743d1912 Mon Sep 17 00:00:00 2001
From: Brendan Lawlor <blawlor@clamsnet.org>
Date: Thu, 22 Aug 2024 20:50:39 +0000
Subject: [PATCH] Bug 35905: (follow-up) Add permission checks to report
 results

---
 .../modules/reports/guided_reports_start.tt   | 26 +++++++++++--------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index 4bac39c5b4..0721c22dc2 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -1101,13 +1101,15 @@
                                                             </li>
                                                         [% END %]
                                                         [% IF header_ro.has_itemnumbers && ( header_ro.cell == 'itemnumber' || header_types.item( header_ro.cell ) == 'itemnumber' ) %]
-                                                            <li class="dropdown-header">Item records</li>
-                                                            <li>
-                                                                <a href="#" data-submit="batch_item_modification" data-toggle="tooltip" data-placement="right" title="Send visible items to batch item modification" class="batch_op send_to_item_mod">Batch item modification</a>
-                                                            </li>
-                                                            <li>
-                                                                <a href="#" data-submit="batch_item_deletion" data-toggle="tooltip" data-placement="right" title="Send visible items to batch item deletion" class="batch_op send_to_item_del">Batch item deletion</a>
-                                                            </li>
+                                                                [% IF ( CAN_user_tools_items_batchmod || CAN_user_tools_items_batchdel ) %]
+                                                                    <li class="dropdown-header">Item records</li>  
+                                                                    <li>
+                                                                        <a href="#" data-submit="batch_item_modification" data-toggle="tooltip" data-placement="right" title="Send visible items to batch item modification" class="batch_op send_to_item_mod">Batch item modification</a>
+                                                                    </li>
+                                                                    <li>
+                                                                        <a href="#" data-submit="batch_item_deletion" data-toggle="tooltip" data-placement="right" title="Send visible items to batch item deletion" class="batch_op send_to_item_del">Batch item deletion</a>
+                                                                    </li>
+                                                                [% END # /IF CAN_user_tools_items_batchmod || CAN_user_tools_items_batchdel %]
                                                         [% END %]
                                                     [% END # /FOREACH header_ro %]
                                                 </ul> <!-- /.dropdown-menu -->
@@ -1188,8 +1190,10 @@
                                                         <span class="data-plain">[% cells.cell | $raw %]</span>
                                                         <div id="itemnumber_autolink" class="btn-group dropup autolink"><a class="btn btn-link dropdown-toggle" role="button" data-toggle="dropdown" href="#">[% cells.cell | $raw %] <b class="caret"></b></a>
                                                             <ul class="dropdown-menu pull-right" role="menu">
-                                                                <li><a target="_blank" href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&itemnumber=[% cells.cell | $raw %]"><i class="fa-fw fa-solid fa-pencil" aria-hidden="true"></i> Edit record</a></li>
-                                                                <li role="separator" class="divider"></li>
+                                                                [% IF CAN_user_editcatalogue_edit_items %]
+                                                                    <li><a target="_blank" href="/cgi-bin/koha/cataloguing/additem.pl?op=edititem&itemnumber=[% cells.cell | $raw %]"><i class="fa-fw fa-solid fa-pencil" aria-hidden="true"></i> Edit record</a></li>
+                                                                    <li role="separator" class="divider"></li>
+                                                                [% END # /IF CAN_user_editcatalogue_edit_items %]
                                                                 <li><a target="_blank" href="/cgi-bin/koha/catalogue/moredetail.pl?itemnumber=[% cells.cell | $raw %]"><i class="fa fa-fw fa-eye"></i> View record</a></li>
                                                             </ul>
                                                         </div>
@@ -1199,10 +1203,10 @@
                                                         <span class="data-plain">[% cells.cell | $raw %]</span>
                                                         <div id="biblionumber_autolink" class="btn-group dropup autolink"><a class="btn btn-link dropdown-toggle" role="button" data-toggle="dropdown" href="#">[% cells.cell | $raw %] <b class="caret"></b></a>
                                                             <ul class="dropdown-menu pull-right" role="menu">
-                                                                [% IF ( CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items ) %]
+                                                                [% IF CAN_user_editcatalogue_edit_catalogue %]
                                                                     <li><a target="_blank" href="/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=[% cells.cell | $raw %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit record</a></li>
                                                                     <li role="separator" class="divider"></li>
-                                                                [% END # /IF CAN_user_editcatalogue_edit_catalogue || CAN_user_editcatalogue_edit_items %]
+                                                                [% END # /IF CAN_user_editcatalogue_edit_catalogue %]
                                                                 <li><a target="_blank" href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% cells.cell | $raw %]"><i class="fa-solid fa-eye"></i> View record</a></li>
                                                             </ul>
                                                         </div>
-- 
2.39.2