From fb8dbb19830b0529b8aab7eb832ea3f030488cb7 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Fri, 23 Aug 2024 13:14:58 +0000 Subject: [PATCH] Bug 35466: (follow-up) Go to next if error, add to indexing call if not Before the previous patch we were indexing with every AddAuthority/ModAuthority call and I assumed we were also indexing during the commity, however, it appears we were not. This patch ensures we push the record and ids into the arrays for indexing during commit. Additionally I add a skip to next record on error, to match biblio behaviour. I also correct a log referring to biblios during authority importing Signed-off-by: Phil Ringnalda --- misc/migration_tools/bulkmarcimport.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index 384fbbb5b3..1ef11a59ad 100755 --- a/misc/migration_tools/bulkmarcimport.pl +++ b/misc/migration_tools/bulkmarcimport.pl @@ -478,6 +478,7 @@ RECORD: foreach my $record ( @{$marc_records} ) { if ($@) { warn "ERROR: Update authority $matched_record_id failed: $@\n"; printlog( { id => $matched_record_id, op => "update", status => "ERROR" } ) if ($logfile); + next RECORD; } else { printlog( { id => $authid, op => "update", status => "ok" } ) if ($logfile); } @@ -498,6 +499,7 @@ RECORD: foreach my $record ( @{$marc_records} ) { if ($@) { warn "ERROR: Insert authority $originalid failed: $@\n"; printlog( { id => $originalid, op => "insert", status => "ERROR" } ) if ($logfile); + next RECORD; } else { printlog( { id => $authid, op => "insert", status => "ok" } ) if ($logfile); } @@ -506,7 +508,7 @@ RECORD: foreach my $record ( @{$marc_records} ) { printlog( { id => $originalid, op => "insert", - status => "warning : biblio not in database and option -insert not enabled, skipping..." + status => "warning : authority not in database and option -insert not enabled, skipping..." } ) if ($logfile); } @@ -518,6 +520,8 @@ RECORD: foreach my $record ( @{$marc_records} ) { 1 #@FIXME: Really always updated? ); } + push @search_engine_record_ids, $authid; + push @search_engine_records, $record; } else { my ( $biblioitemnumber, $itemnumbers_ref, $errors_ref, $record_id ); -- 2.44.0