From 15ce9327b7be05eaa7bec685ab30b3840dce18b6 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 23 Aug 2024 15:29:39 +0000 Subject: [PATCH] Bug 35402: (follow-up) Change a checkin form from POST to GET If you have AllowReturnToBranch enabled and you check in an item which is disallowed by the preference (returned at the wrong branch, for instance) You get a "Connot check in" modal. Previously clicking the "OK" button in this form triggered JS which is supposed to submit a form. However, all the button needs to do is dismiss the modal. The form and the "approve" class on the button are removed by this patch. NOTE: This patch contains indentation changes. To test, apply the patch and set the AllowReturnToBranch system preference to "only at the library that the item is from." - Locate an item belonging to another library and check it out to a patron. - Check in the item. - You should see a modal confirmation, "Cannot check in". - Clicking the "OK" button should dismiss the modal window without triggering a reload of the page. --- .../prog/en/modules/circ/returns.tt | 56 +++++++++---------- 1 file changed, 27 insertions(+), 29 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index 197ad48dd2..74c2e23570 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -540,35 +540,33 @@ -- 2.39.2