From 9ca8b4f9f81aa71330a9c0560263c4d1baa4a758 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 20 Mar 2013 11:01:30 -0400 Subject: [PATCH] [PASSED QA] Bug 9873 - Quiet errors in the log from XSLT.pm If XSLTResultsDisplay is enabled and items in your search results lack a shelving location or a ccode errors will appear in the log complaining of "uninitialized value in hash element." This patch adds a check on these values to quiet the errors. To test, find or create a record with items which have no shelving location and/or no collection code. Perform a search the results for which will include your record. Check for errors in the log. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Cleans up logs for result list quite a bit. Passes all tests and QA script. --- C4/XSLT.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/XSLT.pm b/C4/XSLT.pm index 139ddd2..bab03bc 100644 --- a/C4/XSLT.pm +++ b/C4/XSLT.pm @@ -279,8 +279,8 @@ sub buildKohaItemsNamespace { $status = "available"; } my $homebranch = $item->{homebranch}? xml_escape($branches->{$item->{homebranch}}->{'branchname'}):''; - $location = xml_escape($shelflocations->{$item->{location}}); - $ccode = xml_escape($ccodes->{$item->{ccode}}); + $location = $item->{location}? xml_escape($shelflocations->{$item->{location}}):''; + $ccode = $item->{ccode}? xml_escape($ccodes->{$item->{ccode}}):''; my $itemcallnumber = xml_escape($item->{itemcallnumber}); $xml.= "$homebranch". "$location". -- 1.7.9.5