From b9bc7c25ed8a537155b9da902d012c751860c575 Mon Sep 17 00:00:00 2001 From: PerplexedTheta Date: Tue, 27 Aug 2024 11:48:34 +0100 Subject: [PATCH] Bug 37148 - Move hold to pull column filters to top This bug moves the column filters on the holds to pull page (pendingreserves.pl) to the table header, similar to how it is being done on shelves.pl. This should make it much clearer to users that filtering is possible, and also make the filters float on the page, so they are always visible. To test: a) apply half a dozen holds, with varying item types, shelving locations, holding branches, titles, and collections b) go to pendingreserves.pl c) notice that the filters are in the table's footer, and that you have to scroll down to see them d) APPLY PATCH e) notice that on pendingreserves.pl, the filters present in tfoot are now in thead f) notice that the filters are unchanged, aside from location on page g) notice that the filters now stick to the top of the page, like the headings did h) notice that the headings still change the sort order when clicked i) notice that the filter inputs all still work as expected j) SIGN OFF! :-) Signed-off-by: Martin Renvoize --- .../prog/en/modules/circ/pendingreserves.tt | 87 +++++++++++-------- 1 file changed, 49 insertions(+), 38 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt index cd1c237287b..fe83008077c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt @@ -66,23 +66,42 @@ - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -251,27 +270,6 @@ [% END %] - - - - - - - - - - - - - - - - - - - - -
Pull this many itemsItems availablePatrons with holdsFirst patronTitleLibrariesAvailable barcodesAvailable call numbersAvailable copy numbersAvailable enumerationAvailable item typesAvailable locationsAvailable collectionsEarliest hold dateHold notesPickup locationActionPull this many itemsItems availablePatrons with holdsFirst patronTitleLibrariesAvailable barcodesAvailable call numbersAvailable copy numbersAvailable enumerationAvailable item typesAvailable locationsAvailable collectionsEarliest hold dateHold notesPickup locationAction
[% ELSE %] No items found. @@ -324,11 +322,24 @@ [% MACRO jsinclude BLOCK %] [% INCLUDE 'calendar.inc' %] [% INCLUDE 'datatables.inc' %] + [% Asset.js("lib/jquery/plugins/jquery.dataTables.columnFilter.js") | $raw %] + [% IF print %] + + [% END #/print %] [% INCLUDE 'columns_settings.inc' %]