From 45616d1d1e774fbab05fc6c4bfc4ae1e4acdb456 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adolfo=20Rodr=C3=ADguez?= Date: Mon, 9 Sep 2024 09:20:08 +0200 Subject: [PATCH] bug 37863 Fix checking if a patron is already in the list adding users to a patron card batch If the patron is already in the card batch it won't add it and it will show an error message Test plan: 1 Create or edit an patron card batch 2 Try adding twice or more the same patron. It will show a success message everytime and you will end up with the same patron several times in the card batch 3 Apply patch, restart services 4 Repeat step 2. The first time you click on add user, it will do it and show the success message (Patron 'Patron name' added.), but after that it won't add the user and it will display an error message (Patron 'Patron name' is already in the list.) --- .../prog/en/modules/patroncards/edit-batch.tt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt index c9a17827c1..55873393ad 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ -231,7 +231,12 @@ }; function add_user(borrowernumber) { - $("#bor_num_list").val($("#bor_num_list").val()+borrowernumber+"\r\n"); + var list = $("#bor_num_list").val(); + if (list.indexOf(borrowernumber) == -1) { + $("#bor_num_list").val(list+borrowernumber+"\r\n"); + } else { + return -1; + } } function DeDuplicate() { -- 2.30.2