From 59608090a615b992f16adc75e5d85974793a6349 Mon Sep 17 00:00:00 2001 From: Petro Vashchuk Date: Mon, 9 Sep 2024 13:33:58 +0300 Subject: [PATCH] Bug 37865: Fix uninitialized value warn Use of uninitialized value $op in string eq at /home/vagrant/kohaclone/circ/circulation.pl line 145.: /home/vagrant/kohaclone/circ/circulation.pl This happened because in cases when $op was undef and circulation.pl tried to directly compare it to string. To reproduce: 1. Go to "Check Out" page of a patron, or refresh already opened one. 2. Check your logs for "Use of uninitialized value $op" warn. 3. Apply patch. 4. Repeat step 1 and check that there's no new "Use of uninitialized value $op" error --- circ/circulation.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/circ/circulation.pl b/circ/circulation.pl index 9230347ce0..9e4d3ea5ea 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -113,7 +113,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user ( } ); -my $op = $query->param('op'); +my $op = $query->param('op') // ''; my $override_high_holds = $query->param('override_high_holds'); my $override_high_holds_tmp = $query->param('override_high_holds_tmp'); -- 2.46.0