From 710d5d1fe7496dbb2535670d5f5fca3dea4fe4b3 Mon Sep 17 00:00:00 2001 From: Baptiste Wojtkowski Date: Fri, 9 Aug 2024 16:33:37 +0200 Subject: [PATCH] Bug 37606 - Fix framework export module to escape double quotes When exporting a framework as csv, the exporter does not check the presence of double quote in the fields. Hence, if there is one double quote, the csv is broken. TEST PLAN: 1 - Change a framework to add a field containing double quote in name 2 - Export it in csv 3 - Create a new framework 4 - Import the csv in the new framework -> every fields after the one containing double quotes should be broke. Every other fields should have no subfield 5 - APPLY PATCH 6 - Repeat 2-5 -> everything should be correctly exported --- C4/ImportExportFramework.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm index 3d44d46..16295d6 100644 --- a/C4/ImportExportFramework.pm +++ b/C4/ImportExportFramework.pm @@ -291,6 +291,7 @@ sub _export_table_csv for my $field (@fields) { my $value = $hashRef->{$field} // q||; $value =~ s/[\r\n]//g; + $value =~ s/"/""/g; $$strCSV .= '"' . $value . '",'; } chop $$strCSV; -- 2.43.0