From a44ebd3d5ae080891db51f2cc2991021f36e6230 Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Wed, 11 Sep 2024 14:05:33 +0300 Subject: [PATCH] Bug 37866: Unable to resolve claim from patron details page if syspref ClaimReturnedLostValue is disabled If ones tries to resolve a claim from patrons detail page and syspref ClaimReturnedLostValue is disabled, "Resolve return claim" pop up isn't displayed. Page just jumps to the top of the page. However this works from the patron check out page. This happens because in moremember.tt line 765 we only check if ClaimReturnedLostValue is enabled. In circulation.tt line 1023 we check if either ClaimReturnedLostValue or BundleLostValue syspref is enabled. To test: 1. Disable syspref "ClaimReturnedLostValue" (set used value empty). 2. Find patron with claims (or create them). 3. Navigate to patrons detail page and from there open "Claims" tab. 4. Press "Resolve" button. => Pop up isn't displayed and page jumps to the top of the page. 5. Repeat steps on patrons check out page. => Pop up is displayed. 6. Apply this patch. => Pop up should now be displayed both in patrons details and check out pages. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard --- koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt index 99d09c27078..e876dbddd67 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ -762,7 +762,7 @@ [% Asset.js("js/pages/circulation.js") | $raw %] [% Asset.js("js/checkouts.js") | $raw %] - [% IF Koha.Preference('ClaimReturnedLostValue') %] + [% IF Koha.Preference('ClaimReturnedLostValue') || Koha.Preference('BundleLostValue') %] [% Asset.js("js/resolve_claim_modal.js") | $raw %] [% END %] [% Asset.js("js/holds.js") | $raw %] -- 2.39.2