From ee236c2faee548f5cdf5ec8b1510978c1197dee5 Mon Sep 17 00:00:00 2001 From: Paul Derscheid Date: Thu, 12 Sep 2024 13:21:17 +0000 Subject: [PATCH] Bug 37618: (follow-up) Remove redundant api call --- .../prog/js/modals/place_booking.js | 54 +++++++------------ 1 file changed, 20 insertions(+), 34 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js index 683aa67a7b..604e494b14 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js +++ b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking.js @@ -606,46 +606,32 @@ $("#placeBookingModal").on("show.bs.modal", function (e) { // Set item's home library as default if patron's home library hasn't already populated pickup_library_id let pickup_library_id = $("#pickup_library_id").val(); - const booking_patron_id = $("#booking_patron_id").val(); - if (!pickup_library_id && booking_patron_id) { - $.ajax({ - url: - "/api/v1/patrons?patron_id=" + - booking_patron_id, - dataType: "json", - type: "GET", - }).then(response => { - const [booking_patron] = response; - let is_home; - pickup_library_id = bookable_items.find( - ({ home_library_id, holding_library_id }) => { - is_home = - holding_library_id === home_library_id; - if (is_home) { - return ( - home_library_id === - booking_patron.library_id - ); - } - + if (!pickup_library_id && booking_patron) { + let is_home; + pickup_library_id = bookable_items.find( + ({ home_library_id, holding_library_id }) => { + is_home = + holding_library_id === home_library_id; + if (is_home) { return ( - holding_library_id === + home_library_id === booking_patron.library_id ); } - )?.[ - is_home - ? "home_library_id" - : "holding_library_id" - ]; - if (!pickup_library_id) { - return; + + return ( + holding_library_id === + booking_patron.library_id + ); } + )?.[is_home ? "home_library_id" : "holding_library_id"]; + if (!pickup_library_id) { + return; + } - $("#pickup_library_id") - .val(pickup_library_id) - .trigger("change.select2"); - }); + $("#pickup_library_id") + .val(pickup_library_id) + .trigger("change.select2"); } // Disable patron selection change -- 2.46.0