From 7e50d1980f035ed6441c0058bc79084b1e5ac0f8 Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@theke.io>
Date: Thu, 12 Sep 2024 11:14:22 -0300
Subject: [PATCH] Bug 35655: Only use STOMP if JobsNotificationMethod set to do
 so

This patch makes the background jobs (jobs from now on) enqueue step not
try to connect to the STOMP broker, unless explicitly told to do so.

This is achieved by using a newly introduced system preference
`JobsNotificationMethod` which falls back to STOMP if undefined.

The goal for this patch is to stop flooding the logs on very busy sites
when Rabbit is not being used. This shouldn't predate any efforts on
making the STOMP based jobs brokering mechanism solid and usable.

To test:
1. On clean `main`, run:
   $ ktd --shell
2. Open the logs on a separate terminal:
   $ ktd --shell
  k$ tail -f /var/log/koha/kohadev/*.log
3. Stage some MARC for import
=> SUCCESS: No warnings about STOMP
4. Import the staged records
=> SUCCESS: No warnings about STOMP
5. Stop rabbitmq:
  k$ sudo service rabbitmq-server stop
6. Repeat 2-4
=> FAIL: The logs say it couldn't connect to STOMP
7. Apply this patches and run:
  k$ restart_all
8. Repeat 2-4
=> FAIL: You get the same errors, because it defaults to STOMP and it is
not available
9. Start rabbit:
  k$ sudo service rabbitmq-server start
  k$ restart_all
10. Repeat 2-4
=> SUCCESS: No warnings about STOMP
11. Change the `JobsNotificationMethod` system preference to *polling*
   and stop rabbit:
  k$ sudo service rabbitmq-server stop
  k$ restart_all
12. Repeat 2-4
=> SUCCESS: No warnings about STOMP
13. Sign off :-D

Dedicated to Liz
---
 Koha/BackgroundJob.pm | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm
index 33a6872ec03..dfd3cd335c7 100644
--- a/Koha/BackgroundJob.pm
+++ b/Koha/BackgroundJob.pm
@@ -121,6 +121,11 @@ sub enqueue {
         }
     )->store;
 
+    my $notification_method = C4::Context->preference('JobsNotificationMethod') // 'STOMP';
+
+    return $self->id
+        unless $notification_method eq 'STOMP';
+
     $job_args->{job_id} = $self->id;
 
     my $conn;
-- 
2.46.0