From 8ca2d67b6be06db549ed3b7f5d3db3454eb9a96c Mon Sep 17 00:00:00 2001 From: Kyle Hall Date: Mon, 1 Aug 2022 09:20:03 -0400 Subject: [PATCH] Bug 26282: (QA follow-up) Remove invalid test A cancellation reason is not required, making this test invalid. --- t/db_dependent/Koha/Hold.t | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/t/db_dependent/Koha/Hold.t b/t/db_dependent/Koha/Hold.t index 04cacbffe75..44988e9ff85 100755 --- a/t/db_dependent/Koha/Hold.t +++ b/t/db_dependent/Koha/Hold.t @@ -1092,7 +1092,7 @@ subtest 'change_type() tests' => sub { subtest 'cancel() tests' => sub { - plan tests => 12; + plan tests => 11; $schema->storage->txn_begin; @@ -1172,8 +1172,6 @@ subtest 'cancel() tests' => sub { $get_prepared_letter_called = 0; $hold->cancel({ notify_patron => 1 }); - is( $get_prepared_letter_called, 0, 'GetPreparedLetter not called if notify_patron passed and no cancellation_reason passed' ); - isnt( $hold->cancellationdate, undef, 'cancellationdate gets set to the passed value' ); is( $hold->priority, 0, 'priority gets set to 0' ); is( $hold->cancellation_reason, undef, 'cancellation_reason not passed' ); -- 2.39.3 (Apple Git-146)