From c613ac30fcf8d9d92d6a40e42a3006b7e16075e2 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Wed, 11 Sep 2024 13:03:55 -0300 Subject: [PATCH] Bug 37898: Wrap Patroncards.t inside a transaction This tests leave data on the DB and need to be fixed. This patch does that. To test: 1. Run: $ ktd --shell k$ echo "SELECT COUNT(*) FROM creator_layouts \G" | koha-mysql kohadev 2. Run: k$ prove t/db_dependent/Patroncards.t => SUCCESS: Tests pass 3. Repeat 1 => FAIL: Numbers don't match the original ones! 4. Apply this patch 5. Repeat 2 and 3 => SUCCESS: Tests still pass! => SUCCESS: Numbers match! 6. Sign off :-D Signed-off-by: Martin Renvoize --- t/db_dependent/Patroncards.t | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/t/db_dependent/Patroncards.t b/t/db_dependent/Patroncards.t index 5ae61af1dcd..375b20b7873 100755 --- a/t/db_dependent/Patroncards.t +++ b/t/db_dependent/Patroncards.t @@ -15,20 +15,27 @@ # with Koha; if not, see . use Modern::Perl; + use Test::More tests => 1; -use Test::MockModule; -use t::lib::Mocks; -use t::lib::TestBuilder; -use C4::Patroncards::Layout qw( save new ); +use C4::Patroncards::Layout; +use Koha::Database; + +my $schema = Koha::Database->new->schema; + +subtest 'save() tests' => sub { -subtest '->save' => sub { plan tests => 1; + + $schema->storage->txn_begin; + my $layout = C4::Patroncards::Layout->new( layout_name => "new patron card", - layout_id => '', # The interface send an empty string + layout_id => '', # The interface send an empty string layout_xml => 'some_xml' ); my $layout_id = $layout->save; - ok($layout_id > 0, 'A layout_id should have been returned on ->save'); + ok( $layout_id > 0, 'A layout_id should have been returned on ->save' ); + + $schema->storage->txn_rollback; }; -- 2.46.0