From 6c3cfb7b71aa53031286a5d7471f7245889216cf Mon Sep 17 00:00:00 2001 From: Emmi Takkinen Date: Wed, 5 Jun 2024 10:21:43 +0300 Subject: [PATCH] Bug 31470: Do not change relationship value when adding a patron guarantor Adding new id "relationship" led to unexpected behaviour in relationship handling. If one edits patron with non-patron guarantor and added patron guarantor, non-patron guarantors relatioship field was set as empty value which is first option on select field. This patch removes code which sets relationship select field to use first value of option automatically when patron guarantor is added. Also thi patch add missing id to mandatory relatioship field. To test: 1. Add or edit patron. 2. Add non-patron guarantor for patron and select some value as their relationship. 3. Then add a patron guarantor. => Note that non-patron guarantors relationship is empty. 4. Apply this patch. 5. Repeat steps 1 to 3. => Relationship shouldn't change. Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 2 +- koha-tmpl/intranet-tmpl/prog/js/members.js | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index 73432008c44..1c9e15ece82 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -703,7 +703,7 @@ legend.collapsed i.fa.fa-caret-down::before {
  • [% IF mandatoryrelationship %] - [% ELSE %]