Bugzilla – Attachment 172101 Details for
Bug 36932
koha-plack: Add parameter for specifically enabling Starman development environment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36932: Add development parameter to koha-plack
Bug-36932-Add-development-parameter-to-koha-plack.patch (text/plain), 2.71 KB, created by
Marcel de Rooy
on 2024-09-27 08:49:59 UTC
(
hide
)
Description:
Bug 36932: Add development parameter to koha-plack
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-09-27 08:49:59 UTC
Size:
2.71 KB
patch
obsolete
>From c0ac34361d73b52fbc8885f4c7408ad1e068fa14 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 23 May 2024 06:47:44 +0000 >Subject: [PATCH] Bug 36932: Add development parameter to koha-plack >Content-Type: text/plain; charset=utf-8 > >Test plan: >NOTE: Needs dev_install or ktd. > >[1] Add a die in a script somewhere to simulate a crash. > For example in opac-main.pl: die "Line 43"; >[2] Run koha-plack --restart YOUR_CLONE (without -dev) and hit that page. > See no dev output? >[3] Run koha-plack --restart -dev YOUR_CLONE and hit page again. > See dev output? >[4] BONUS: Do a koha-plack --reload YOUR_CLONE (without -dev). Hit page. > Verify that environment did not change. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > debian/scripts/koha-plack | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > >diff --git a/debian/scripts/koha-plack b/debian/scripts/koha-plack >index 28f5430c72..88564449c5 100755 >--- a/debian/scripts/koha-plack >+++ b/debian/scripts/koha-plack >@@ -61,6 +61,7 @@ $scriptname -h|--help > --debugger-location Specify the host:port for your debugger tool (defaults > to localhost:9000) > --debugger-path Specify the path for the debugger library >+ --development|-dev Enable development environment > --quiet|-q Make the script quiet about non existent instance names > (useful for calling from another scripts). > --help|-h Display this help message >@@ -91,19 +92,14 @@ start_plack() > > instance_user="${instancename}-koha" > >- environment="deployment" >+ if [ -z "$development_environment" ]; then environment="deployment"; else environment="development"; fi > daemonize="--daemonize" > logging="--access-log /var/log/koha/${instancename}/plack.log \ > --error-log /var/log/koha/${instancename}/plack-error.log" > max_requests_and_workers="--max-requests ${PLACK_MAX_REQUESTS} --workers ${PLACK_WORKERS}" > >- if [ "$DEV_INSTALL" = "1" ]; then >- # Maybe we should switch off debug_mode if DEV_INSTALL is not set? >- environment="development" >- fi >- > if [ "$debug_mode" = "yes" ]; then >- environment="development" >+ # Maybe we should switch off debug_mode if DEV_INSTALL is not set? > daemonize="" > logging="" # remote debugger takes care > max_requests_and_workers="--workers 1" >@@ -465,6 +461,9 @@ while [ $# -gt 0 ]; do > --debugger-path) > debugger_path="$2" > shift 2 ;; >+ -dev|--development_environment) >+ development_environment=1 >+ shift ;; > -*) > die "Error: invalid option switch ($1)" ;; > *) >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36932
:
167069
|
167256
| 172101