Bugzilla – Attachment 172234 Details for
Bug 37730
Batch patron modification table horizontal scroll causes headers to mismatch
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37730: Batch patron modification header scroll
Bug-37730-Batch-patron-modification-header-scroll.patch (text/plain), 1.76 KB, created by
David Nind
on 2024-09-30 18:33:29 UTC
(
hide
)
Description:
Bug 37730: Batch patron modification header scroll
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-09-30 18:33:29 UTC
Size:
1.76 KB
patch
obsolete
>From 16db28c175be7a2815878edde8a9698738ebe0e2 Mon Sep 17 00:00:00 2001 >From: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> >Date: Mon, 30 Sep 2024 15:03:23 +0000 >Subject: [PATCH] Bug 37730: Batch patron modification header scroll > >When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl, >there is a point where the table header leaves the normal flow of >the page to stick to the top of the screen instead. When this >occurs, the header becomes fixed: if scrolling through the table >horizontally, only the body will move. This is an issue as it means >that in this situation, some column headers cannot be viewed and the >data does not necessarily match the header under which it is found. > >This patch resolves this issue by allowing the header to scroll >horizontally and ensuring that the width of the column headers >still match that of the columns themselves. > >Test plan: > >A) Reproduce the bug as per Pedro's intructions: > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index 46ef2f417d..e398e1241b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -461,7 +461,8 @@ > [% IF borrowers %] > let patron_table = KohaTable("borrowerst", { > "order": [[ 1, "asc" ]], >- "autoWidth": false, >+ "autoWidth": true, >+ "scrollX": true, > }, table_settings); > > $("#selectallbutton").click(function() { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37730
:
172229
|
172234
|
172235
|
172276