From 238b2623e653f7dc6ffe8f4947aec5e39691f46f Mon Sep 17 00:00:00 2001 From: Aleisha Amohia Date: Mon, 20 Mar 2023 22:51:55 +0000 Subject: [PATCH] Bug 33260: Add view_generated_notices user permission Signed-off-by: Laura Escamilla Signed-off-by: kelly Signed-off-by: David Nind Signed-off-by: Martin Renvoize --- ...dd_tools_view_generated_notices_permission.pl | 16 ++++++++++++++++ .../data/mysql/mandatory/userpermissions.sql | 1 + .../prog/en/includes/permissions.inc | 5 +++++ t/Koha/Auth/Permissions.t | 1 + 4 files changed, 23 insertions(+) create mode 100755 installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl diff --git a/installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl b/installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl new file mode 100755 index 00000000000..e2d9f58d9fb --- /dev/null +++ b/installer/data/mysql/atomicupdate/bug_33260_-_add_tools_view_generated_notices_permission.pl @@ -0,0 +1,16 @@ +use Modern::Perl; + +return { + bug_number => "33260", + description => "Show message queue on staff interface and make notices printable", + up => sub { + my ($args) = @_; + my ( $dbh, $out ) = @$args{qw(dbh out)}; + + $dbh->do( + q{ INSERT IGNORE INTO permissions (module_bit, code, description) VALUES (13, 'view_generated_notices', 'View and print generated notices') } + ); + + say $out "Added user permission view_generated_notices"; + }, +}; diff --git a/installer/data/mysql/mandatory/userpermissions.sql b/installer/data/mysql/mandatory/userpermissions.sql index 83808b97a2d..ffb9719df98 100644 --- a/installer/data/mysql/mandatory/userpermissions.sql +++ b/installer/data/mysql/mandatory/userpermissions.sql @@ -100,6 +100,7 @@ INSERT INTO permissions (module_bit, code, description) VALUES (13, 'moderate_comments', 'Moderate patron comments'), (13, 'edit_notices', 'Define notices'), (13, 'edit_notice_status_triggers', 'Set notice/status triggers for overdue items'), + (13, 'view_generated_notices', 'View and print generated notices'), (13, 'edit_quotes', 'Edit quotes for quote-of-the-day feature'), (13, 'view_system_logs', 'Browse the system logs'), (13, 'inventory', 'Perform inventory (stocktaking) of your catalog'), diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc index f5396703e76..1997f98051e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc @@ -557,6 +557,11 @@ Define notices ([% name | html %]) + [%- CASE 'view_generated_notices' -%] + + View and print generated notices + + ([% name | html %]) [%- CASE 'edit_patrons' -%] Perform batch modification of patrons diff --git a/t/Koha/Auth/Permissions.t b/t/Koha/Auth/Permissions.t index 426b105855a..f591ce46794 100755 --- a/t/Koha/Auth/Permissions.t +++ b/t/Koha/Auth/Permissions.t @@ -259,6 +259,7 @@ subtest 'superlibrarian tests' => sub { 'CAN_user_tools_edit_calendar' => 1, 'CAN_user_tools_edit_notice_status_triggers' => 1, 'CAN_user_tools_edit_notices' => 1, + 'CAN_user_tools_view_generated_notices' => 1, 'CAN_user_tools_edit_patrons' => 1, 'CAN_user_tools_edit_quotes' => 1, 'CAN_user_tools_export_catalog' => 1, -- 2.46.2