From 1afb056eee0df0d47e0a7bfe39cb5a8d48fc4f1f Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Tue, 15 Oct 2024 23:50:00 +0000 Subject: [PATCH] Bug 38183: Get the active tab number from data-attribute To test: 1. Have more than 1 staff member who can manage suggestions 2. Create some suggestions 3. Move some suggestions to different statuses (Pending/Accepted/Rejected) so you have multiple tabs on the "Suggestions management" page. 4. Go to the first tab, check some suggestions, and click "Select manager" under "Update manager". 5. Pick a new manager, notice nothing changes on that tab. 6. Now look at the last tab in your list of tabs, see the suggestion manager has been set incorrectly to the last tab. 7. APPLY PATCH 8. Try 4-5 again. The manager should be selected correctly. 9. Try setting the manaager from every tab, making sure it works right. Signed-off-by: Phil Ringnalda Signed-off-by: Jonathan Druart --- .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index a826bc0d0d1..3c86a275699 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -736,7 +736,7 @@ Check all | Uncheck all

- +
@@ -1299,8 +1299,8 @@ [% INCLUDE 'calendar.inc' %] [% SET filter = "suggestions_managers" %] [% PROCESS patron_search_modal columns => columns, modal_title => t("Select manager"), patron_search_modal_id => 'patron_search_modal_manager_' _ loop.count, table_id => 'patron_search_modal_manager_table_' _ loop.count %] [% PROCESS patron_search_js columns => columns, actions => ["select"], preview_on_name_click => 1, table_id => 'patron_search_modal_manager_table_' _ loop.count, callback => 'select_manager' %] -- 2.34.1