From 30929c90589735656be84f05308e9cc94018d2a9 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Fri, 20 Sep 2024 09:07:42 +0000 Subject: [PATCH] Bug 37892: (QA follow-up) Fix condition in memberentry Patron may be undefined. So the test may crash. Also there is an issue with operator precedence. Signed-off-by: Martin Renvoize --- members/memberentry.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/members/memberentry.pl b/members/memberentry.pl index eb92536fcc6..d8cf8013611 100755 --- a/members/memberentry.pl +++ b/members/memberentry.pl @@ -285,7 +285,9 @@ if ( ( $op eq 'cud-save' || $op eq 'cud-insert' ) } foreach my $guarantor (@guarantors) { - if ( ( $op eq 'cud-save' || $op eq 'cud-insert' ) && ($guarantor->is_child ) || $guarantor->is_guarantee || $patron->is_guarantor) { + if ( ( $op eq 'cud-save' || $op eq 'cud-insert' ) + && ( $guarantor->is_child || $guarantor->is_guarantee || ( $patron && $patron->is_guarantor ) ) ) + { push @errors, 'ERROR_guarantor_is_guarantee'; } } -- 2.47.0