Bugzilla – Attachment 172956 Details for
Bug 35906
Add bookable option on itemtypes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35906: (QA follow-up) Ensure we return effective_bookable
Bug-35906-QA-follow-up-Ensure-we-return-effectiveb.patch (text/plain), 1.26 KB, created by
Paul Derscheid
on 2024-10-18 10:59:29 UTC
(
hide
)
Description:
Bug 35906: (QA follow-up) Ensure we return effective_bookable
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2024-10-18 10:59:29 UTC
Size:
1.26 KB
patch
obsolete
>From 4d1be882b7c6e353b3149935defb49faa648e6df Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 18 Oct 2024 09:10:00 +0100 >Subject: [PATCH] Bug 35906: (QA follow-up) Ensure we return effective_bookable > >The API wasn't including the effective_bookable value in responses > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >--- > Koha/Item.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Item.pm b/Koha/Item.pm >index e3ba7ed679..84a1088a9b 100644 >--- a/Koha/Item.pm >+++ b/Koha/Item.pm >@@ -1756,14 +1756,14 @@ Overloaded to_api method to ensure item-level itypes is adhered to. > =cut > > sub to_api { >- my ($self, $params) = @_; >+ my ( $self, $params ) = @_; > > my $response = $self->SUPER::to_api($params); >- my $overrides = {}; >- >- $overrides->{effective_item_type_id} = $self->effective_itemtype; > >+ my $overrides = {}; >+ $overrides->{effective_item_type_id} = $self->effective_itemtype; > $overrides->{effective_not_for_loan_status} = $self->effective_not_for_loan_status; >+ $overrides->{effective_bookable} = $self->effective_bookable; > > return { %$response, %$overrides }; > } >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35906
:
161397
|
161638
|
161744
|
161961
|
162242
|
162365
|
162465
|
162466
|
162467
|
162468
|
162469
|
162470
|
162472
|
163291
|
163292
|
163293
|
163294
|
163295
|
163547
|
163548
|
163549
|
163550
|
163551
|
164579
|
164580
|
164581
|
164582
|
164583
|
164584
|
164585
|
165437
|
166866
|
166867
|
166868
|
166869
|
166870
|
166871
|
168120
|
168121
|
168122
|
168160
|
168161
|
168162
|
168163
|
168164
|
170187
|
170188
|
170189
|
170190
|
170191
|
170582
|
170583
|
170584
|
170585
|
170586
|
172127
|
172128
|
172129
|
172130
|
172131
|
172132
|
172941
|
172945
|
172950
|
172951
|
172952
|
172953
|
172954
|
172955
|
172956
|
172957
|
172958
|
172959
|
172960
|
172961
|
173324
|
173325
|
173326
|
173327
|
173328
|
173329
|
173330
|
173331
|
173332
|
173333
|
173334
|
173335
|
173893