From c2650ac44649d108e5f4c11b22bd39ce9e1a3e52 Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Wed, 23 Oct 2024 15:33:51 -0400 Subject: [PATCH] Bug 38246: Only check unresolved claims To test: 1. Set up sysprefs: - Set any non-empty value for ClaimReturnedLostValue - Set AutoClaimReturnStatusOnCheckout to "found in library" - Set AutoClaimReturnStatusOnCheckin to "returned by patron" 2. Check out an item to a patron 3. On the patron's account page, click the "Claim Return" button next to that checkout 4. Check the item in. Note the message that the claim was auto-resolved. 5. Return to the patron's account page and open the Claims Returned tab --> Note that the claim is resolved and hidden 6. Click the "Show all 1 claims" link to view the hidden claim. Make a note of the resolution code and timestamp. 7. Check the item out again --> Note the message saying that the claim was resolved, even though it was already resolved previously 8. View the return claim again --> Note that the timestamp and resolution code have changed 9. Apply patch and restart_all 10. Repeat steps 2-8 with a new item --> Note you do not get a claim resolved message on checkout this time --> Note that the timestamp and resolution code remain the same before and after the checkout --- circ/circulation.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/circ/circulation.pl b/circ/circulation.pl index 2ae9447cf6..6839f957f3 100755 --- a/circ/circulation.pl +++ b/circ/circulation.pl @@ -442,6 +442,7 @@ if (@$barcodes && $op eq 'cud-checkout') { my $claims = Koha::Checkouts::ReturnClaims->search( { itemnumber => $item->id, + resolution => undef, } ); if ( $claims->count ) { -- 2.39.2