From fe64bcf087c7947b67f391c5cb4454f3ed6f1909 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 23 Oct 2024 15:34:09 +0200 Subject: [PATCH] Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Signed-off-by: Pedro Amorim Signed-off-by: Phil Ringnalda --- .../includes/html_helpers/tables/items/catalogue_detail.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc index 0f15e19a52d..8ccce6c8968 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc @@ -836,7 +836,9 @@ }); [% END %] - update_columns_visibility(settings); + if ( api.data().length ) { + update_columns_visibility(settings); + } if ( drawcallback ) { drawcallback(this); } }, -- 2.34.1