From cbea6a681606f8d61da5ec7c0a56746df8b317df Mon Sep 17 00:00:00 2001
From: Paul Derscheid <paul.derscheid@lmscloud.de>
Date: Thu, 24 Oct 2024 12:18:40 +0000
Subject: [PATCH] Bug 38222: (follow-up) Reset overflow property of modal-body
 to prevent clipping of combobox options instead of position: fixed
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Also remove the inlined styles on the unordered list. Bootstrap's dropdown handles all of this.

Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Signed-off-by: LEBSimonsen <simonsen@bz-sh.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../intranet-tmpl/prog/en/includes/modals/cancel_booking.inc  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc
index 5cc699d8999..19c3074dd91 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/modals/cancel_booking.inc
@@ -8,7 +8,7 @@
                     <h1 class="modal-title" id="cancelBookingLabel">Cancel booking</h1>
                     <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button>
                 </div>
-                <div class="modal-body">
+                <div class="modal-body overflow-visible">
                     <div id="cancel_booking_result"></div>
                     <input type="hidden" name="booking_id" id="cancel_booking_id">
                     <p>Are you sure you want to cancel this booking?</p>
@@ -17,7 +17,7 @@
                         <div class="combobox-container">
                             <label for="cancellation-reason" class="form-label">Cancellation Reason:</label>
                             <input type="text" id="cancellation-reason" name="cancellation_reason" class="form-control" />
-                            <ul id="cancellation-reason-list" class="dropdown-menu position-fixed" style="max-height: 200px; overflow-y: auto; max-width: fit-content;">
+                            <ul id="cancellation-reason-list" class="dropdown-menu">
                                 [% IF booking_cancellation.count %]
                                     [% FOR reason IN booking_cancellation %]
                                         <li>
-- 
2.47.0