Attachment 173432 Details for Bug 36317 – Bug 36317: Add unit test

[patch] Bug 36317: Add unit test

Bug-36317-Add-unit-test.patch (text/plain), 1.92 KB, created by Martin Renvoize (ashimema) on 2024-10-28 08:26:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-28 08:26:09 UTC

Size: 1.92 KB

patch

obsolete

>From 97a3acd2915bb5aedc0a1b07c6c2986c3ef802cb Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 18 Mar 2024 15:18:27 +0100
>Subject: [PATCH] Bug 36317: Add unit test
>
>If fails it shows :
>DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Column 'itemnumber' in where clause is ambiguous at /kohadevbox/koha/Koha/Objects.pm line 399
>
>Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/db_dependent/Koha/Biblio.t | 23 ++++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Koha/Biblio.t b/t/db_dependent/Koha/Biblio.t
>index 0fde70957f8..0576acca567 100755
>--- a/t/db_dependent/Koha/Biblio.t
>+++ b/t/db_dependent/Koha/Biblio.t
>@@ -1350,7 +1350,7 @@ subtest 'get_marc_notes() UNIMARC tests' => sub {
> };
> 
> subtest 'host_items() tests' => sub {
>-    plan tests => 7;
>+    plan tests => 8;
> 
>     $schema->storage->txn_begin;
> 
>@@ -1381,6 +1381,27 @@ subtest 'host_items() tests' => sub {
>     is_deeply( [ $host_items->get_column('itemnumber') ],
>         [ $host_item_1->itemnumber, $host_item_2->itemnumber ] );
> 
>+    my $transfer = $builder->build_object(
>+        {
>+            class => 'Koha::Item::Transfers',
>+            value => {
>+                itemnumber => $host_item_1->itemnumber,
>+                frombranch => $host_item_1->holdingbranch,
>+            }
>+        }
>+    );
>+    ok(
>+        $host_items->search(
>+            {},
>+            {
>+                join     => 'branchtransfers',
>+                order_by => 'branchtransfers.daterequested'
>+            }
>+        )->as_list,
>+        "host_items can be used with a join query on itemnumber"
>+    );
>+    $transfer->delete;
>+
>     t::lib::Mocks::mock_preference( 'EasyAnalyticalRecords', 0 );
>     $host_items = $biblio->host_items;
>     is( ref($host_items),   'Koha::Items' );
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 36317: 163131 | 163155 | 163334 | 163335 | 163338 | 164238 | 164239 | 173432 | 173433