Attachment 173433 Details for Bug 36317 – Bug 36317: Koha::Biblio->host_items must use me.itemnumber

[patch] Bug 36317: Koha::Biblio->host_items must use me.itemnumber

Bug-36317-KohaBiblio-hostitems-must-use-meitemnumb.patch (text/plain), 1.11 KB, created by Martin Renvoize (ashimema) on 2024-10-28 08:26:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-28 08:26:12 UTC

Size: 1.11 KB

patch

obsolete

>From 52f1fb91666e2fcdca48e73ad52e719ac1a36710 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 14 Mar 2024 11:24:54 +0100
>Subject: [PATCH] Bug 36317: Koha::Biblio->host_items must use me.itemnumber
>
>Koha::Biblio->host_items fails with search_ordered() because of ambiguous column 'itemnumber' in where clause.
>It must use me.itemnumber like in Koha::Biblio->items
>
>Test plan :
>prove t/db_dependent/Koha/Biblio.t
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Biblio.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index 67242a33088..2d332b03d1b 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -658,7 +658,7 @@ sub host_items {
> 
>     my $host_itemnumbers = $self->_host_itemnumbers;
> 
>-    return Koha::Items->search( { itemnumber => { -in => $host_itemnumbers } } );
>+    return Koha::Items->search( { "me.itemnumber" => { -in => $host_itemnumbers } } );
> }
> 
> =head3 _host_itemnumbers
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 36317: 163131 | 163155 | 163334 | 163335 | 163338 | 164238 | 164239 | 173432 | 173433