From a9c7fd3536d425d8de6d0d111c3ac6e665585496 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 30 Oct 2024 17:41:45 +0000 Subject: [PATCH] Bug 38305: Can't delete or archive suggestions This patch corrects JS on the suggestions page so that the delete, archive, and unarchive controls work. The patch also modifies the markup of the "Delete" button so that it is consisten with other pages. To test, apply the patch and go to the suggestions page in the staff interface. - Log in to the staff interface as a user with "suggestions_manage" permission. - If necessary, create a few suggestions to test with. - From the table of suggestions, click the secondary menu on the "Edit" button for one of the suggestions. - Choose "Delete." You should get a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. - Choose "Archive." There won't be a confirmation, and the title should disappear from the list. - To test whether the suggestion was archived, search for it using the sidebar form, checking the "Include archived" checkbox. The suggestion should show up in the list with an "Archived" label. - Clicking the "Edit" secondary menu on the archived suggestion should trigger a menu with an "Unarchive" option. Click that and confirm that the suggestion is no longer archived. - Now log in as a user with only "suggestions_delete" permission but not "suggestions_manage" - In the list of suggestions each title should have a "delete" button. - Clicking the delete button should trigger a confirmation dialog. Both the "OK" and "Cancel" options should work as expected. --- .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index a37d78c111e..ece937647aa 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -882,7 +882,7 @@ [% ELSIF CAN_user_suggestions_suggestions_delete %] - + [% END %] @@ -1437,7 +1437,7 @@ $("." + target).toggle(); }); - $("button.trigger_action").on("click", function(e) { + $(".trigger_action").on("click", function(e) { var id = $(this).data('suggestionid'); var op = $(this).data('op'); if ( op == 'cud-delete' && !confirm(_("Are you sure you want to delete this suggestion?")) ) { -- 2.39.5