From eb73a46b036f040a249db366c89763477acd8763 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Mon, 4 Nov 2024 14:56:35 +0000
Subject: [PATCH] Bug 38347: Fix style of sidebar form submit button on
 bookings to collect page

This patch fixes the markup of the sidebar form on the bookings to
collect page, and adds the correct "btn btn-primary" class to the submit
button.

To test, apply the patch and go to Circulation -> Bookings to collect.

In the sidebar form, confirm that the submit button has the same yellow
"primary" style as other submit buttons, and that it fills the width of
the sidebar.

Sponsored-by: Athens County Public Libraries
---
 .../prog/en/modules/circ/pendingbookings.tt   | 69 +++++++++----------
 1 file changed, 33 insertions(+), 36 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
index 0b8e603503..78eb211586 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingbookings.tt
@@ -51,43 +51,40 @@
             <!-- Filters & Navigation -->
             <div class="col-md-2 order-sm-2 order-md-1">
                 <aside>
-                    <div id="filters">
-                        <form id="bookingsf">
-                            <fieldset class="brief">
-                                <h4>Refine results</h4>
-                                <ol>
-                                    <li>
-                                        <label for="library">Holding library:</label>
-                                        <select name="library" id="library">
-                                            [% SET libraries = Branches.all( only_from_group => 1 ) %]
-                                            [% IF libraries.size != 1 %]
-                                                <option value="">Any</option>
+                    <form id="bookingsf">
+                        <fieldset class="brief">
+                            <h4>Refine results</h4>
+                            <ol>
+                                <li>
+                                    <label for="library">Holding library:</label>
+                                    <select name="library" id="library">
+                                        [% SET libraries = Branches.all( only_from_group => 1 ) %]
+                                        [% IF libraries.size != 1 %]
+                                            <option value="">Any</option>
+                                        [% END %]
+                                        [% FOREACH l IN libraries %]
+                                            [% IF (l.branchcode == branchcode) %]
+                                                <option value="[% l.branchcode | html %]" selected="selected">[% l.branchname | html %]</option>
+                                            [% ELSE %]
+                                                <option value="[% l.branchcode | html %]">[% l.branchname | html %]</option>
                                             [% END %]
-                                            [% FOREACH l IN libraries %]
-                                                [% IF (l.branchcode == branchcode) %]
-                                                    <option value="[% l.branchcode | html %]" selected="selected">[% l.branchname | html %]</option>
-                                                [% ELSE %]
-                                                    <option value="[% l.branchcode | html %]">[% l.branchname | html %]</option>
-                                                [% END %]
-                                            [% END %]
-                                        </select>
-                                    </li>
-                                    <li>
-                                        <label for="from">Starts after: </label>
-                                        <input type="text" size="10" id="from" name="from" value="[% from | html %]" class="flatpickr" data-date_to="to"/>
-                                    </li>
-                                    <li>
-                                        <label for="to">Starts before: </label>
-                                        <input type="text" size="10" id="to" name="to" value="[% to | html %]" class="flatpickr"/>
-                                    </li>
-                                </ol>
-
-                                <fieldset class="action">
-                                    <input type="submit" name="run_report" value="Submit" class="submit"/>
-                                </fieldset>
-                            </fieldset>
-                        </form>
-                    </div>
+                                        [% END %]
+                                    </select>
+                                </li>
+                                <li>
+                                    <label for="from">Starts after: </label>
+                                    <input type="text" size="10" id="from" name="from" value="[% from | html %]" class="flatpickr" data-date_to="to"/>
+                                </li>
+                                <li>
+                                    <label for="to">Starts before: </label>
+                                    <input type="text" size="10" id="to" name="to" value="[% to | html %]" class="flatpickr"/>
+                                </li>
+                            </ol>
+                        </fieldset>
+                        <fieldset class="action">
+                            <input type="submit" name="run_report" value="Submit" class="btn btn-primary "/>
+                        </fieldset>
+                    </form>
                     [% INCLUDE 'circ-nav.inc' %]
                 </aside>
             </div>
-- 
2.39.5