From 6f8d1855845012b5068c96e88172a06d5f9353b1 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi <tomascohen@theke.io> Date: Mon, 4 Nov 2024 10:29:16 -0300 Subject: [PATCH] Bug 38342: Pass the value to exception to avoid warnings This patch makes the exception on bad enum values in Koha::Object->store not print a warning in the event of stringifying the exception. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Booking.t => FAIL: You get this warnings: ``` Use of uninitialized value in sprintf at /kohadevbox/koha/Koha/Exceptions/Object.pm line 84. ``` 2. Apply this patch 3. Repeat 1 => SUCCESS: No more uninitialized values warnings 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Koha/Object.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/Koha/Object.pm b/Koha/Object.pm index 0511d271573..8e254623bde 100644 --- a/Koha/Object.pm +++ b/Koha/Object.pm @@ -210,6 +210,7 @@ sub store { property => $property =~ /(\w+\.\w+)$/ ? $1 : $property, # results in table.column without quotes or backtics + value => $self->$property, ) if $type eq 'enum'; } } -- 2.47.0