Attachment 174195 Details for Bug 38378 – Bug 38378: Serial frequency deletion needs to be converted to POST from GET

[patch] Bug 38378: Serial frequency deletion needs to be converted to POST from GET

Bug-38378-Serial-frequency-deletion-needs-to-be-co.patch (text/plain), 2.00 KB, created by Lari Strand on 2024-11-07 13:32:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lari Strand

Created: 2024-11-07 13:32:17 UTC

Size: 2.00 KB

patch

obsolete

>From 28766d68c803019dfad9098f992b7b9e2ef7d696 Mon Sep 17 00:00:00 2001
>From: lmstrand <lmstrand@gmail.com>
>Date: Thu, 7 Nov 2024 14:27:55 +0200
>Subject: [PATCH] Bug 38378: Serial frequency deletion needs to be converted to
> POST from GET
>
>---
> serials/subscription-frequencies.pl | 31 ++++++++++++++++-------------
> 1 file changed, 17 insertions(+), 14 deletions(-)
>
>diff --git a/serials/subscription-frequencies.pl b/serials/subscription-frequencies.pl
>index 77fa4c268b..05a01813d8 100755
>--- a/serials/subscription-frequencies.pl
>+++ b/serials/subscription-frequencies.pl
>@@ -88,28 +88,31 @@ if($op && ($op eq 'cud-savenew' || $op eq 'cud-savemod')) {
>     } else {
>         AddSubscriptionFrequency($frequency);
>     }
>-} elsif($op && $op eq 'cud-del') {
>+} elsif($op && $op eq 'del') {
>     my $frequencyid = $input->param('frequencyid');
> 
>     if ($frequencyid) {
>-        my $confirm = $input->param('confirm');
>-        if ($confirm) {
>-            DelSubscriptionFrequency($frequencyid);
>+        my @subs = GetSubscriptionsWithFrequency($frequencyid);
>+        if (@subs) {
>+            $template->param(
>+                frequencyid => $frequencyid,
>+                still_used => 1,
>+                subscriptions => \@subs
>+            );
>         } else {
>-            my @subs = GetSubscriptionsWithFrequency($frequencyid);
>-            if (@subs) {
>-                $template->param(
>-                    frequencyid => $frequencyid,
>-                    still_used => 1,
>-                    subscriptions => \@subs
>-                );
>-            } else {
>-                DelSubscriptionFrequency($frequencyid);
>-            }
>+            $template->param(
>+                frequencyid => $frequencyid,
>+                still_used => 0
>+            );
>+            DelSubscriptionFrequency($frequencyid);
>         }
>     }
> }
> 
>+elsif($op && $op eq 'cud-del') {
>+    my $frequencyid = $input->param('frequencyid');
>+    DelSubscriptionFrequency($frequencyid);
>+}
> 
> my @frequencies = GetSubscriptionFrequencies();
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 38378: 174076 | 174077 | 174195 | 174231 | 174309 | 174434 | 174444