From a6548a1d77a5cb5bd52dc24e3231d7f6a34bb8d9 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 5 Sep 2024 12:57:57 +0000
Subject: [PATCH] Bug 37311: (follow-up) Use Bootstrap badge classes for some
 statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
---
 .../prog/en/modules/admin/smtp_servers.tt          | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
index e09e0828ca..5e6cdd3cab 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
@@ -402,7 +402,8 @@
                     {
                         "data": function( row, type, val, meta ) {
                             if ( row.debug ) {
-                                return "[% tp("Active", "On") | html %]";
+                                let result = '<span class="badge text-bg-warning">' + "[% tp("Active", "On") | html %]" + '</span>';
+                                return result;
                             }
                             else {
                                 return _("");
@@ -414,7 +415,8 @@
                     {
                         "data": function( row, type, val, meta ) {
                             if ( row.is_default ) {
-                                return _("Default");
+                                let result = '<span class="badge text-bg-success">' + _("Default") + '</span>';
+                                return result;
                             } else {
                                 return "";
                             }
@@ -432,14 +434,6 @@
                         "orderable": false
                     }
                 ],
-                createdRow: function (row, data, dataIndex) {
-                    if ( data.is_default ) {
-                        $(row).addClass('default');
-                    }
-                    if ( data.debug ) {
-                        $(row).addClass('debug');
-                    }
-                },
             });
 
             $('#smtp_servers').on( "click", '.delete_server', function () {
-- 
2.39.5