From 65dcfd42e1cce2891e5b928ed751375509e88e2c Mon Sep 17 00:00:00 2001
From: Yanjun Li <yanjun.li@bywatersolutions.com>
Date: Fri, 15 Nov 2024 23:14:55 +0000
Subject: [PATCH] Bug 38302: (follow-up) Remove duplicate click handler and
 modify button class

This follow-up patch removes the unnecessarily added click handler, and modifies the delete button class. The confirmation dialog and delete function work.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
---
 .../intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt    | 3 ---
 .../prog/en/modules/virtualshelves/tables/shelves_results.tt   | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
index 289c95e888..926afb5c1f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt
@@ -701,9 +701,6 @@
                 $("body").on("click", ".deleteshelf", function(){
                     return confirmDelete(MSG_CONFIRM_DELETE_LIST);
                 });
-                $("body").on("click", ".delete-list",function(){
-                    return confirm(_("Are you sure you want to delete this list?"));
-                });
             });
         [% END # /IF op == 'list' %]
 
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
index abc6272c1d..ae6f4ad1e4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/tables/shelves_results.tt
@@ -54,7 +54,7 @@
         [%~ action_block = action_block _ '<input type="hidden" name="shelfnumber" value="' _ shelfnumber  _ '" />' ~%]
         [%~ action_block = action_block _ '<input type="hidden" name="public" value="' _ public _ '" />' ~%]
         [%~ action_block = action_block _ '<input type="hidden" name="referer" value="list" />' ~%]
-        [%~ action_block = action_block _ '<button type="submit" class="delete-list btn btn-default btn-xs"><i class="fa fa-trash-can"></i> ' _ t("Delete") _ '</button>' ~%]
+        [%~ action_block = action_block _ '<button type="submit" class="deleteshelf btn btn-default btn-xs"><i class="fa fa-trash-can"></i> Delete</button>' ~%]
         [%~ action_block = action_block _ '</form>' ~%]
     [%~ END ~%]
     [%~ IF public AND allow_transfer ~%]
-- 
2.39.5