From feeb859331eca9d2801edd8470720772a7565efc Mon Sep 17 00:00:00 2001 From: David Cook Date: Thu, 21 Nov 2024 22:48:14 +0000 Subject: [PATCH] Bug 38444: (QA follow-up) tidy Signed-off-by: David Cook --- t/db_dependent/selenium/patrons_search.t | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/t/db_dependent/selenium/patrons_search.t b/t/db_dependent/selenium/patrons_search.t index 76cadfb10d..b5f508b9dd 100755 --- a/t/db_dependent/selenium/patrons_search.t +++ b/t/db_dependent/selenium/patrons_search.t @@ -63,8 +63,8 @@ my $firstname = q|fir's"tname \123 ❤|; my $address = q|add'res"s \123 ❤|; my $email = q|abad_email@example\123 ❤.com|; my ( - $attribute_type, $attribute_type_searchable_1, $attribute_type_searchable_2, - $attribute_type_searchable_not_default, $patron_category, $library + $attribute_type, $attribute_type_searchable_1, $attribute_type_searchable_2, + $attribute_type_searchable_not_default, $patron_category, $library ); sub setup { $patron_category = $builder->build_object( @@ -75,9 +75,7 @@ sub setup { ); push @cleanup, $patron_category; - $library = $builder->build_object( - { class => 'Koha::Libraries', value => { branchname => $branchname } } - ); + $library = $builder->build_object( { class => 'Koha::Libraries', value => { branchname => $branchname } } ); push @cleanup, $library; my @patrons; @@ -360,14 +358,21 @@ subtest 'Search patrons' => sub { plan tests => 1; - $patron_category->replace_library_limits( [$library->id] ); + $patron_category->replace_library_limits( [ $library->id ] ); C4::Context->set_preference( 'PatronsPerPage', 5 ); $driver->get( $base_url . "/members/members-home.pl" ); clear_filters(); $s->fill_form( { 'search_patron_filter' => 'test_patron' } ); $s->submit_form; sleep $DT_delay && $s->wait_for_ajax; - is( $driver->find_element('//div[@id="'.$table_id.'_info"]')->get_text, sprintf('Showing 1 to %s of %s entries (filtered from %s total entries)', $PatronsPerPage, 26, $total_number_of_patrons), 'Search works when category of patrons is limited to a library we are not signed in at' ); + is( + $driver->find_element( '//div[@id="' . $table_id . '_info"]' )->get_text, + sprintf( + 'Showing 1 to %s of %s entries (filtered from %s total entries)', $PatronsPerPage, 26, + $total_number_of_patrons + ), + 'Search works when category of patrons is limited to a library we are not signed in at' + ); }; -- 2.39.5