Bugzilla – Attachment 17514 Details for
Bug 10070
History of anonymous searches is not kept
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10070: Anonymous search history is not being set in the cookie
Bug-10070-Anonymous-search-history-is-not-being-se.patch (text/plain), 1.44 KB, created by
Chris Cormack
on 2013-04-17 22:07:45 UTC
(
hide
)
Description:
Bug 10070: Anonymous search history is not being set in the cookie
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2013-04-17 22:07:45 UTC
Size:
1.44 KB
patch
obsolete
>From 09fe487354558dd451a97b3035d7d2573e97fe1c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Wed, 17 Apr 2013 15:37:57 +0200 >Subject: [PATCH] Bug 10070: Anonymous search history is not being set in the > cookie > >Test plan: >1 - turn on EnableOpacSearchHistory >2 - launch some searches at the opac >3 - go to your search history >4 - there is no history! >5 - apply this patch >6 - retry steps 1 to 3 >7 - your history search is available! > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> > >This does fix the bug, but does undo the change to make the cookie >utf-8 safe, however I think that change was done in the wrong way so >I am happy to sign this off >--- > opac/opac-search.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index 677b7c2..2502768 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -652,7 +652,7 @@ for (my $i=0;$i<@servers;$i++) { > $newsearchcookie = $cgi->cookie( > -name => 'KohaOpacRecentSearches', > # We uri_escape the whole freezed structure so we're sure we won't have any encoding problems >- -value => uri_escape_utf8(freeze(\@recentSearches)), >+ -value =>freeze(\@recentSearches), > -expires => '' > ); > $cookie = [$cookie, $newsearchcookie]; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10070
:
17499
|
17514
|
17666
|
17709
|
17710
|
17774
|
17779