Bugzilla – Attachment 17545 Details for
Bug 10074
Encoding problems for login and installer
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 10074 - Encoding problems in templates
SIGNED-OFF-Bug-10074---Encoding-problems-in-templa.patch (text/plain), 1.69 KB, created by
Bernardo Gonzalez Kriegel
on 2013-04-19 13:35:10 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 10074 - Encoding problems in templates
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2013-04-19 13:35:10 UTC
Size:
1.69 KB
patch
obsolete
>From e990b46186a80fe7aac2ab3e78c9a692638c665d Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@gmail.com> >Date: Thu, 18 Apr 2013 15:07:40 -0300 >Subject: [PATCH] [SIGNED-OFF] Bug 10074 - Encoding problems in templates >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Bug 6554 patched output_html_with_http_headers to encode utf8 data, and Templates.pm to expect utf8 data to be encoded. >(At least) the staff login screen outputs directly to STDOUT (Auth.pm does, WHICH IS WRONG!) and wasn't fixed to do the encoding first. > >This patch makes it use output_html_with_http_headers and solves the problem. > >Changed 'use' for 'require' as jcamins and marcelr suggested. > >Regards >To+ > >Sponsored-by: Universidad Nacional de Córdoba >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >--- > C4/Auth.pm | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index ca061b5..811151b 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -19,6 +19,7 @@ package C4::Auth; > > use strict; > use warnings; >+ > use Digest::MD5 qw(md5_base64); > use Storable qw(thaw freeze); > use URI::Escape; >@@ -1065,14 +1066,10 @@ sub checkauth { > LibraryName => C4::Context->preference("LibraryName"), > ); > $template->param( %info ); >-# $cookie = $query->cookie(CGISESSID => $session->id >-# ); >- print $query->header( >- -type => 'text/html', >- -charset => 'utf-8', >- -cookie => $cookie >- ), >- $template->output; >+ >+ require C4::Output; >+ C4::Output::output_html_with_http_headers( $query, $cookie, >+ $template->output); > safe_exit; > } > >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10074
:
17527
|
17528
|
17529
|
17530
|
17531
|
17532
|
17533
|
17534
|
17542
|
17545
|
17546
|
17548
|
17549
|
17550