From 8501ef792ccfef23cbd6301eb3ad1553514e1a6a Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Wed, 18 Dec 2024 08:48:22 -0500 Subject: [PATCH] Bug 36127: Adjust default HOLDPLACED and HOLD_CHANGED notices to use TT To test: 1. Apply patch 2. reset_all (or start your testing environment in the first place) 3. Edit system preferences: emailLibrarianWhenHoldIsPlaced - Enable ReplyToDefault - enter a fake/test email address ExpireReservesMaxPickupDelay - Allow ExpireReservesAutoFill - Do ExpireReservesAutoFillEmail - same email address as ReplyToDefault 4. Place two holds on the same bib for two different patrons, Patron A and Patron B 5. Edit an item on that bib to set a call number (if it doesn't have one already) 6. Check in that item to set Patron A's hold to waiting 7. Edit the expiration date on Patron A's hold to yesterday's date To do this in KTD: ktd --shell koha-mysql kohadev UPDATE reserves SET expirationdate = WHERE borrowernumber = ; 8. Run misc/cronjobs/holds/cancel_expired_holds.pl to automatically cancel the expired hold and fill the next one 9. Open koha-mysql again and run the following query to view the generated notices: SELECT subject, content FROM message_queue WHERE to_address = ''; --> Confirm that HOLDPLACED and HOLD_CHANGED notices were both generated --> Confirm that all information has been filled in correctly for those notices --- installer/data/mysql/en/mandatory/sample_notices.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml index e054a5a0fa..63470e5315 100644 --- a/installer/data/mysql/en/mandatory/sample_notices.yml +++ b/installer/data/mysql/en/mandatory/sample_notices.yml @@ -2022,7 +2022,7 @@ tables: message_transport_type: email lang: default content: - - "A hold has been placed on the following item : <> (<>) by the user <> <> (<>)." + - "A hold has been placed on the following item: [% biblio.title %] ([% biblio.biblionumber %]) by the user [% INCLUDE 'patron-title.inc' patron => borrower, no_title => 1, no_html => 1 %]." - module: reserves code: HOLD_CHANGED @@ -2033,12 +2033,12 @@ tables: message_transport_type: email lang: default content: - - "The patron picking up <> (<>) has changed to <> <> (<>)." + - "The patron picking up [% biblio.title %] ([% item.barcode %]) has changed to [% INCLUDE 'patron-title.inc' patron => borrower, no_title => 1, no_html => 1 %]." - "Please update the hold information for this item." - - "Title: <>" - - "Author: <>" - - "Item: <>" - - "Pickup location: <>" + - "Title: [% biblio.title %]" + - "Author: [% biblio.author %]" + - "Call number: [% item.itemcallnumber %]" + - "Pickup location: [% branch.branchname %]" - module: reserves code: HOLD_REMINDER -- 2.34.1