Bugzilla – Attachment 175772 Details for
Bug 36285
Staff UI form fieldset styling needs update
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36285: Preparation: Move ERM specific styling to all of koha Staff forms
Bug-36285-Preparation-Move-ERM-specific-styling-to.patch (text/plain), 3.22 KB, created by
Pedro Amorim
on 2024-12-19 15:27:45 UTC
(
hide
)
Description:
Bug 36285: Preparation: Move ERM specific styling to all of koha Staff forms
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2024-12-19 15:27:45 UTC
Size:
3.22 KB
patch
obsolete
>From 9e99be7e27db6c5a12de1d27053f518777871eaf Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 8 Mar 2024 11:58:33 -0100 >Subject: [PATCH] Bug 36285: Preparation: Move ERM specific styling to all of > koha Staff forms > >This is just a proof of concept > >1) Before applying the patch, access some (or all) of the links below. >2) Apply patch >3) Run yarn css:build to rebuild scss >4) Refresh each of the pages and notice the changes > >Some form examples: ><staff_url>/cgi-bin/koha/acqui/supplier.pl?op=enter ><staff_url>/cgi-bin/koha/serials/serials-home.pl ><staff_url>/cgi-bin/koha/serials/subscription-add.pl ><staff_url>/cgi-bin/koha/erm/eholdings/local/titles/add ><staff_url>/cgi-bin/koha/virtualshelves/shelves.pl?op=add_form&referer=list ><staff_url>/cgi-bin/koha/suggestion/suggestion.pl?op=add_form&branchcode=CPL > >Side menu changes: >/cgi-bin/koha/members/members-home.pl >/cgi-bin/koha/serials/serials-search.pl # Press Search > >A problem arises for some inputs that have the size property e.g. size="4" on the new purchase suggestion form, and others. >With this new change, these inputs lose their initial enforced "smaller" size. >I think this should be iterated and made more streamlined and use a .input-small class of the size. >--- > .../intranet-tmpl/prog/css/src/_forms.scss | 24 +++++++++++++++++++ > .../prog/js/vue/components/ERM/Main.vue | 18 -------------- > 2 files changed, 24 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss >index ce631535eec..9029e7638b2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_forms.scss >@@ -1,6 +1,30 @@ > fieldset { > @include card; > >+ .v-select, >+ select, >+ textarea, >+ input{ >+ &:not([type="submit"]):not([type="search"]):not([type="button"]):not([type="checkbox"]):not([type="radio"]) { >+ border-color: rgba(60, 60, 60, 0.26); >+ border-width: 1px; >+ border-radius: 4px; >+ min-width: 30%; >+ line-height: 1.5; >+ } >+ } >+ >+ .v-select, >+ select { >+ display: inline-block; >+ background-color: white; >+ width: 30%; >+ } >+ >+ .flatpickr-input { >+ width: 30%; >+ } >+ > legend { > border-bottom: 0 none; > color: #696969; >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue >index 3eaf6dd4891..dbf360b5c51 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/Main.vue >@@ -176,24 +176,6 @@ export default { > padding-left: 2em; > font-size: 100%; > } >- >-form .v-select { >- display: inline-block; >- background-color: white; >- width: 30%; >-} >- >-.v-select, >-input:not([type="submit"]):not([type="search"]):not([type="button"]):not([type="checkbox"]):not([type="radio"]), >-textarea { >- border-color: rgba(60, 60, 60, 0.26); >- border-width: 1px; >- border-radius: 4px; >- min-width: 30%; >-} >-.flatpickr-input { >- width: 30%; >-} > #navmenulist ul li a.current.disabled { > background-color: inherit; > border-left: 5px solid #e6e6e6; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36285
:
162969
| 175772 |
175773
|
175774
|
175775
|
175776