From 8e539fe844caf31186229fed4bea040b34cd456a Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Fri, 20 Dec 2024 12:43:14 -0500 Subject: [PATCH] Bug 38766: Use uri filter for all parameters in referer link Also fixes the confirmation message for deleting. To test: 1. Go to Acquisitions and create some invoices i. Search for a vendor (can submit a blank search box) ii. Click on vendor name iii. Click "Receive shipments" button iv. In the "Receive a new shipment" section, enter any value in the "Vendor invoice" field and click "Next" v. Click the "My Vendor" breadcrumb and repeat iii-iv a few times 2. Go to Acquisitions > Invoices 3. Specify search filters for shipment to/from dates (that include the invoices you entered) and search for invoices 4. Try opening, closing, and deleting individual invoices using the Action menu --> Internal server error! "The given date does not match the date format (iso)". --> Also, note that there is no confirmation dialog when deleting 5. Apply patch 6. Repeat steps 2-4 --> Confirm that invoices can be opened and closed using the drop-down menu with no issue --> Confirm that both open and closed invoices can be deleted with no issue, and that a confirmation message displays before deleting Note for QA: search for $KohaDates within invoices.tt, and confirm that the $KohaDates filter is now only used for display, never for Internal data storage/flow Signed-off-by: Brendan Lawlor --- .../intranet-tmpl/prog/en/modules/acqui/invoices.tt | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt index aa8f4d8fab..716f60b00a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt @@ -103,16 +103,16 @@
  • Details
  • [% IF invoice.closedate %] [% IF CAN_user_acquisition_reopen_closed_invoices %] -
  • Reopen
  • +
  • Reopen
  • [% END %] [% ELSE %] [% IF CAN_user_acquisition_edit_invoices %] -
  • Close
  • +
  • Close
  • [% END %] [% END # /IF invoice.closedate %] [% UNLESS invoice.receivedbiblios || invoice.receiveditems %] [% IF CAN_user_acquisition_delete_invoices %] -
  • Delete
  • +
  • Delete
  • [% END %] [% END %] @@ -439,9 +439,6 @@ }); }); - $(".delete_invoice").click(function(){ - return confirmDelete(_("Are you sure you want to delete this invoice?")); - }); var resultst = $("table.result").dataTable($.extend(true, {}, dataTablesDefaults, { "paging": false, "columnDefs": [ -- 2.39.5