From 5f277b9c74f49ff3a2435fb3d862ff5ee77a95c8 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 24 Dec 2024 10:42:21 +0000 Subject: [PATCH] Bug 38782: Remove concat in background process The ud_provider->{report_type} is only defined on ->harvest_sushi, meaning it'll never be defined here. We don't need this anyway. The filename should be the filename of the file being manually uploaded. We only need this concat logic for COUNTER files being generated by Koha following a SUSHI harvest, and that works. This also gets rid of a warning when running the tests --- Koha/BackgroundJob/ErmSushiHarvester.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/BackgroundJob/ErmSushiHarvester.pm b/Koha/BackgroundJob/ErmSushiHarvester.pm index 5dadc0b60fd..da4721952bb 100644 --- a/Koha/BackgroundJob/ErmSushiHarvester.pm +++ b/Koha/BackgroundJob/ErmSushiHarvester.pm @@ -92,7 +92,7 @@ sub process { usage_data_provider_id => $ud_provider->erm_usage_data_provider_id, file_content => $args->{file_content}, date_uploaded => POSIX::strftime( "%Y%m%d%H%M%S", localtime ), - filename => $ud_provider->name . "_" . $ud_provider->{report_type}, + filename => $ud_provider->name, } ] ); -- 2.39.5