From 4ed65909f4b02b5ebfe5bcca9e04f834e8bd1e0e Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Tue, 24 Dec 2024 10:58:54 +0000 Subject: [PATCH] Bug 38782: Fix erm_custom_reports.t DRY superlibrarian declarion to top for all test methods. Apply same fix from before i.e. mock_userenv prove t/db_dependent/api/v1/erm_custom_reports.t --- t/db_dependent/api/v1/erm_custom_reports.t | 51 +++++----------------- 1 file changed, 11 insertions(+), 40 deletions(-) diff --git a/t/db_dependent/api/v1/erm_custom_reports.t b/t/db_dependent/api/v1/erm_custom_reports.t index 1317c61761e..274044ea9a7 100755 --- a/t/db_dependent/api/v1/erm_custom_reports.t +++ b/t/db_dependent/api/v1/erm_custom_reports.t @@ -45,6 +45,17 @@ my $sushi_counter_5_response_TR_J1 = decode_json( read_file($sushi_response_file my $report_items = $sushi_counter_5_response_TR_J1->{Report_Items}; my $sushi_counter_TR_J1 = Koha::ERM::EUsage::SushiCounter->new( { response => $sushi_counter_5_response_TR_J1 } ); +my $librarian = $builder->build_object( + { + class => 'Koha::Patrons', + value => { flags => 2**28 } + } +); +my $password = 'thePassword123'; +$librarian->set_password( { password => $password, skip_validation => 1 } ); +my $userid = $librarian->userid; +t::lib::Mocks::mock_userenv( { number => $userid } ); + subtest "monthly_report" => sub { plan tests => 17; @@ -64,16 +75,6 @@ subtest "monthly_report" => sub { ] ); - my $librarian = $builder->build_object( - { - class => 'Koha::Patrons', - value => { flags => 2**28 } - } - ); - my $password = 'thePassword123'; - $librarian->set_password( { password => $password, skip_validation => 1 } ); - my $userid = $librarian->userid; - my $patron = $builder->build_object( { class => 'Koha::Patrons', @@ -162,16 +163,6 @@ subtest "yearly_report" => sub { ] ); - my $librarian = $builder->build_object( - { - class => 'Koha::Patrons', - value => { flags => 2**28 } - } - ); - my $password = 'thePassword123'; - $librarian->set_password( { password => $password, skip_validation => 1 } ); - my $userid = $librarian->userid; - my $patron = $builder->build_object( { class => 'Koha::Patrons', @@ -251,16 +242,6 @@ subtest "metric_types_report" => sub { ] ); - my $librarian = $builder->build_object( - { - class => 'Koha::Patrons', - value => { flags => 2**28 } - } - ); - my $password = 'thePassword123'; - $librarian->set_password( { password => $password, skip_validation => 1 } ); - my $userid = $librarian->userid; - my $patron = $builder->build_object( { class => 'Koha::Patrons', @@ -346,16 +327,6 @@ subtest "provider_rollup_report" => sub { ] ); - my $librarian = $builder->build_object( - { - class => 'Koha::Patrons', - value => { flags => 2**28 } - } - ); - my $password = 'thePassword123'; - $librarian->set_password( { password => $password, skip_validation => 1 } ); - my $userid = $librarian->userid; - my $patron = $builder->build_object( { class => 'Koha::Patrons', -- 2.39.5