From 8d200d640537e78392c74acadec99ee5345b4da0 Mon Sep 17 00:00:00 2001 From: Andrew Fuerste Henry Date: Fri, 27 Dec 2024 19:03:30 +0000 Subject: [PATCH] Bug 38790: Add classes to item information on moredetail.pl to test: 1 - Have a bib with multiple items 2 - view those items on the Items tab (moredetail.pl), confirm various parts of the page are not classed and are therefore hard to target with CSS, etc 3 - apply patch 4 - reload page, observe there are classes on things but the display and data have not changed Signed-off-by: David Nind --- .../prog/en/modules/catalogue/moredetail.tt | 76 +++++++++---------- 1 file changed, 38 insertions(+), 38 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt index 651cbf64ea..fd4d50127d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt @@ -57,29 +57,29 @@
    -
  1. Biblionumber: [% biblionumber | html %] 
  2. +
  3. Biblionumber: [% biblionumber | html %] 
  4. [% UNLESS ( item_level_itypes ) %] -
  5. Item type: [% itemtypename | html %] 
  6. +
  7. Item type: [% itemtypename | html %] 
  8. [% END %] [% IF ( rentalcharge ) %] -
  9. Rental charge:[% rentalcharge | $Price %] 
  10. +
  11. Rental charge:[% rentalcharge | $Price %] 
  12. [% END %] [% IF ( rentalcharge_daily ) %] -
  13. Daily rental charge:[% rentalcharge_daily | $Price %] 
  14. +
  15. Daily rental charge:[% rentalcharge_daily | $Price %] 
  16. [% END %] [% IF ( rentalcharge_hourly ) %] -
  17. Hourly rental charge:[% rentalcharge_hourly | $Price %] 
  18. +
  19. Hourly rental charge:[% rentalcharge_hourly | $Price %] 
  20. [% END %] -
  21. ISBN: [% isbn | html %] 
  22. -
  23. Publication details:[% place | html %] [% publishercode | html %] [% publicationyear | html %] 
  24. +
  25. ISBN: [% isbn | html %] 
  26. +
  27. Publication details:[% place | html %] [% publishercode | html %] [% publicationyear | html %] 
  28. [% IF ( volumeddesc ) %] -
  29. Volume: [% volumeddesc | html %]
  30. +
  31. Volume: [% volumeddesc | html %]
  32. [% END %] -
  33. Physical details: [% pages | html %] [% illus | html %] [% size | html %] 
  34. +
  35. Physical details: [% pages | html %] [% illus | html %] [% size | html %] 
  36. [% IF ( bnotes ) %] -
  37. Notes: [% bnotes | html %]
  38. +
  39. Notes: [% bnotes | html %]
  40. [% END %] -
  41. +
  42. No. of items: [% count | html %] [% IF ( hiddencount ) %] @@ -129,28 +129,28 @@
      -
    1. Home library: [% Branches.GetName( ITEM_DAT.homebranch ) | html %] 
    2. +
    3. Home library: [% Branches.GetName( ITEM_DAT.homebranch ) | html %] 
    4. [% IF ( item_level_itypes ) %] -
    5. Item type: [% ITEM_DAT.itype | html %] 
    6. +
    7. Item type: [% ITEM_DAT.itype | html %] 
    8. [% END %] [% IF ( ITEM_DAT.ccode) %] -
    9. Collection: [% ITEM_DAT.ccode | html %]
    10. +
    11. Collection: [% ITEM_DAT.ccode | html %]
    12. [% END %] -
    13. Item call number: [% ITEM_DAT.itemcallnumber | html %]
    14. +
    15. Item call number: [% ITEM_DAT.itemcallnumber | html %]
    16. [% IF ( ITEM_DAT.displaycopy ) %] -
    17. Copy number: [% ITEM_DAT.copyvol | html %] 
    18. +
    19. Copy number: [% ITEM_DAT.copyvol | html %] 
    20. [% END %] [% IF ( ITEM_DAT.location ) %] -
    21. +
    22. Shelving location: [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.location', authorised_value => ITEM_DAT.location ) | html %]
    23. [% END %] [% IF ( ITEM_DAT.replacementprice ) %] -
    24. Replacement price: [% ITEM_DAT.replacementprice | $Price %] 
    25. +
    26. Replacement price: [% ITEM_DAT.replacementprice | $Price %] 
    27. [% END %] [% IF ITEM_DAT.materials %] -
    28. Materials specified: [% ITEM_DAT.materials | html %]
    29. +
    30. Materials specified: [% ITEM_DAT.materials | html %]
    31. [% END %]
    @@ -176,8 +176,8 @@
      -
    1. Current library: [% Branches.GetName( ITEM_DAT.holdingbranch ) | html %] 
    2. -
    3. +
    4. Current library: [% Branches.GetName( ITEM_DAT.holdingbranch ) | html %] 
    5. +
    6. Checkout status: [% SET checkout = ITEM_DAT.object.checkout %] [% IF ( checkout ) %] @@ -193,14 +193,14 @@ [% END %]
    7. [% IF ITEM_DAT.object.checkout.renewals_count %] -
    8. +
    9. Current renewals: [% ITEM_DAT.object.checkout.renewals_count | html %] [ View ]
    10. [% END %] [% IF itemlostloop %] -
    11. +
    12. Lost status: [% IF ( CAN_user_circulate ) %] [% SET ClaimReturnedLostValue = Koha.Preference('ClaimReturnedLostValue') %] @@ -245,7 +245,7 @@ [% END %] [% IF itemdamagedloop %] -
    13. +
    14. Damaged status: [% IF ( CAN_user_circulate ) %]
      @@ -280,7 +280,7 @@ [% END %] [% IF itemwithdrawnloop %] -
    15. +
    16. Withdrawn status: [% IF ( CAN_user_circulate ) %] @@ -322,7 +322,7 @@

      Priority

        -
      1. +
      2. Exclude from local holds priority: [% INCLUDE 'csrf-token.inc' %] @@ -342,7 +342,7 @@
      3. -
      4. +
      5. Bookable: @@ -386,7 +386,7 @@
          [% IF ITEM_DAT.basketno %] -
        1. +
        2. Order date: [% IF ( CAN_user_acquisition_order_manage ) %] [% ITEM_DAT.orderdate | $KohaDates %] @@ -401,7 +401,7 @@ [% END %] [% IF ITEM_DAT.dateaccessioned %] -
        3. +
        4. Accession date: [% IF ( CAN_user_acquisition_order_receive && ITEM_DAT.invoiceid ) %] [% ITEM_DAT.dateaccessioned | $KohaDates %] @@ -412,13 +412,13 @@ [% END %] [% IF ( ITEM_DAT.invoicenumber ) %] -
        5. +
        6. Invoice number: [% ITEM_DAT.invoicenumber | html %]
        7. [% END %] -
        8. +
        9. Total checkouts: [% IF ( ITEM_DAT.issues ) %] [% ITEM_DAT.issues | html %] @@ -428,13 +428,13 @@ (View item's checkout history)
        10. -
        11. +
        12. Last seen: [% IF ( ITEM_DAT.datelastseen ) %] [% ITEM_DAT.datelastseen | $KohaDates with_hours => 1 %] [%END %]
        13. -
        14. +
        15. Last borrowed: [% IF (ITEM_DAT.datelastborrowed ) %][% ITEM_DAT.datelastborrowed | $KohaDates %][% END %]
        16. @@ -446,7 +446,7 @@ [% END %] [% FOR i IN ITEM_DAT.old_issues %] [% SET b = i.patron %] -
        17. +
        18. [% IF loop.first %] Last borrower: [% ELSE %] @@ -456,20 +456,20 @@
        19. [% END %] [% IF ( ITEM_DAT.paidfor ) %] -
        20. +
        21. Paid for?: [% INCLUDE 'patron-title.inc' patron=ITEM_DAT.paidfor.patron hide_patron_infos_if_needed=1 %] on [% ITEM_DAT.paidfor.created_on | $KohaDates %]
        22. [% END %] [% IF ( ITEM_DAT.enumchron ) %] -
        23. +
        24. Serial enumeration: [% ITEM_DAT.enumchron | html %] 
        25. [% END %] -
        26. +
        27. Public note: [% IF ( CAN_user_editcatalogue_edit_items ) %]
          @@ -483,7 +483,7 @@ [% END %]
        28. -
        29. +
        30. Non-public note: [% IF ( CAN_user_editcatalogue_edit_items ) %] -- 2.39.5