From ba51c02d3670eea7c99aebbb5247e866f2c6e921 Mon Sep 17 00:00:00 2001 From: Pedro Amorim Date: Wed, 18 Dec 2024 11:02:51 +0000 Subject: [PATCH] Bug 38738: Only close select element if needed Preparation: Create additional fields for table 'subscription', visit: /cgi-bin/koha/admin/additional-fields.pl?tablename=subscription 2 text fields, one repeatable, one not-repeatable 2 AV fields, one repeatable, one not-repeatable 2 MARC fields, one 'get' and one 'set', both non-repeatable, MARC field 942$c Test plan, apply both patches: 1) Add a new serial subscription, visit: /cgi-bin/koha/serials/subscription-add.pl 2) Set the mandatory "Record" input (e.g. '112'). Click the 'Next' and press 'Ok' on the alert box. 3) Notice the message 'This message should only show if a select input is present' only shows for select inputs, i.e. it's only closing the element when it needs to Signed-off-by: Jonathan Druart --- .../prog/en/includes/additional-fields-entry.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc index 4c42e905d31..c6561dbdafe 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/additional-fields-entry.inc @@ -76,7 +76,9 @@ [% END %] [% END %] [% END %] - + [% IF field.marcfield || !field.repeatable %] + + [% END %] [% IF !search_form %] (Authorised values for [% authorised_value_category | html %]) [% IF field.marcfield && field.marcfield_mode == 'get' %] -- 2.34.1