From 6adee980166a8a4eb4eb97a863dcc54da90a9a33 Mon Sep 17 00:00:00 2001 From: Emily Lamancusa Date: Tue, 7 Jan 2025 08:37:48 -0500 Subject: [PATCH] Bug 38793: Don't dismiss modal before submitting form Remove the bs-data-dismiss attribute from the "cancel transfer" button on the Wrong Transfer modal. The "cancel transfer" button's JS works by adding a hidden input and then submitting the form - we don't want Bootstrap to dismiss the modal before the embedded form has been submitted. To test: 0. Set up system preferences: TransfersBlockCirc - Don't block AutomaticConfirmTransfer - Do 1. Find or create an item that belongs to a branch other than the logged-in branch 2. Check in the item to trigger a Return to Home transfer 3. Click OK on the modal to confirm the transfer 4. Check in the item again to trigger a Wrong Transfer modal 5. Click the "Cancel transfer" button on the modal 6. Navigate to the bib for that item and check the item status --> The transfer wasn't cancelled - the item is still in transit 7. Apply patch and refresh the page 8. Repeat steps 4-6 --> Item shows as available - the transfer was cancelled successfully --- koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt index a47222d99d..0f02b7771c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt @@ -615,7 +615,7 @@ - + -- 2.34.1