From f5ee8d2e001bf96eb0966488b0af61b7be999b46 Mon Sep 17 00:00:00 2001 From: Phil Ringnalda Date: Thu, 9 Jan 2025 15:14:26 -0800 Subject: [PATCH] Bug 38853: Make 'Cancel selected' on holds table work Because 'Cancel selected' on the table of existing holds uses $("#cancel_modal_form #inputs").empty; rather than empty();, it fails to clear out whatever things are in there before it puts in the things it wants. That leaves things in a confused state, and makes it fail to actually cancel holds. Test plan: 1. Without the patch, add a hold to any bib record 2. Select the checkbox for the hold you placed, then click 'Cancel selected' and confirm that you want to cancel 3. Note that there's no message box about a background job having been enqueued, and no matter how long you wait, the hold doesn't go away 4. Apply patch, repeat step 2, note that there's now a message box, and when the background job finishes, that the hold has been deleted. Sponsored-by: Chetco Community Public Library Signed-off-by: David Nind Signed-off-by: Pedro Amorim --- koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt index 437f32c1894..22bd8a8ab9e 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ -1919,7 +1919,7 @@ e.preventDefault(); if($('.holds_table .select_hold:checked').length) { cancel_link = $(this); - $("#cancel_modal_form #inputs").empty; + $("#cancel_modal_form #inputs").empty(); biblionumbers.forEach( function(biblionumber){ $("#cancel_modal_form #inputs").append(''); }); -- 2.39.5